This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
feat: enhance tooltip to accept a custom wrapper #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nvi
reviewed
Dec 2, 2022
There was a problem hiding this comment.
@georgesimos It looks fine, but before I approve it, can we add a test around this new capability?
src/components/Tooltip/Tooltip.tsx
Outdated
| content: string | React.ReactElement; | ||
|
|
||
| /** The wrapper that contains the contnet */ | ||
| contentWrapper?: React.ElementType; |
There was a problem hiding this comment.
optional: I'd rename that to just wrapper
|
🎉 This PR is included in version 0.135.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The tooltip component is a bit limited, so I introduced the content wrapper that will enhance the tooltip capability to modify the content container, e.g. background colour or adding an arrow!
Changes
Testing