Changed rule_for_reference to use timestamps where possible #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @rules.detect{ |rule| _parsetime(rule['_from']) <= reference && _parsetime(rule['_to']) > reference } | ||
| @rules.detect do |rule| | ||
| if rule['from'] and rule['to'] | ||
| from = Time.at(rule['from'].to_i / 1000.0) |
There was a problem hiding this comment.
Can you refactor this logic into a private parsetime function? (similar to _parsetime)
| end | ||
| end | ||
|
|
||
| def _read_timestamp timestamp #:nodoc: |
There was a problem hiding this comment.
I called the function _read_timestamp, I also added a begin/rescue/end block, in case the timestamp is malformed. Feel free to pull in the changes and then rename/refactor as you see fit,
|
Awesome! |
panthomakos
added a commit
that referenced
this pull request
May 16, 2012
Changed rule_for_reference to use timestamps where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while hunting for the DST bug, I noticed that the code was parsing strings also when timestamps were present, so I slightly changed the rule_for_reference code to use timestamps, if present. I tried executing rule_for_reference 10000 times in a row, and it shows that using timestamps is roughly 9 times faster than parsing a string with strptime.
The existing tests are now using the new functionality, and I added a new test (and a data without timestamps) to test the case where no timestamps are available.
If during the existence of this library you have already found a reason why timestamps should not be used, just discard this pull request.