Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .ruby-version file to .gitignore #86

Merged
merged 1 commit into from
Mar 11, 2018
Merged

Add .ruby-version file to .gitignore #86

merged 1 commit into from
Mar 11, 2018

Conversation

AlexWayfer
Copy link
Contributor

No description provided.

panthomakos
panthomakos reviewed Jan 31, 2018
View reviewed changes
Copy link
Owner

@panthomakos panthomakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, as well as some other files in here like .rvmrc, should only be specified in a developer's global git ignore configuration - not in every repo.

@AlexWayfer
Copy link
Contributor Author

This, as well as some other files in here like .rvmrc, should only be specified in a developer's global git ignore configuration - not in every repo.

I have projects (commercial) with .ruby-version and Gemfile.lock in git.

.DS_Store and .idea is the platofrom- or environment-specific.

.ruby-version is common file, not only for rbenv. And .rvmrc deprecated in favor of .ruby-version and .ruby-gemset.

panthomakos
panthomakos approved these changes Mar 11, 2018
View reviewed changes
Copy link
Owner

@panthomakos panthomakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Seems reasonable enough.

@panthomakos panthomakos merged commit 0abc0d9 into panthomakos:master Mar 11, 2018
@AlexWayfer AlexWayfer deleted the add-ruby-version-file-to-gitignore branch March 26, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panthomakos panthomakos panthomakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWayfer @panthomakos