Fix inclusion in translation units with exceptions disabled. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If exceptions are disabled via `-fno-exceptions` or `INJA_NOEXCEPTION`, the use of try-catch is disallowed by the compiler. This patch makes does two things: * Gates the use of try-catch in one translation unit on the definition of `INJA_NOEXCEPTION`. * Make it such that translation units compiled with `-fno-exceptions` but no `INJA_NOEXCEPTION` implicitly sets `INJA_NOEXCEPTION`. In the specific case of `ifstream::open`, setting the exceptions bits without exceptions enabled should trip an assertion just like INJA_ABORT. The nice message will not be present however, but that is absent when using INJA_ABORT as well. After this patch, inja can be successfully included without issue.
|
Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If exceptions are disabled via
-fno-exceptions, the use of try-catch isdisallowed by the compiler.
This patch does two things:
INJA_NOEXCEPTION.-fno-exceptionsbut noINJA_NOEXCEPTIONimplicitly setsINJA_NOEXCEPTION.In the specific case of
ifstream::open, setting the exceptions bits withoutexceptions enabled should trip an assertion just like INJA_ABORT. The nice
message will not be present however, but that is absent when using INJA_ABORT as
well.
After this patch, inja can be successfully included without issue.