Fix issue with python_bundle_create over multiple targets

pantsbuild · Mar 26, 2017 · 0b30d7c · 0b30d7c
1 parent a402344
commit 0b30d7c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/python/pants/backend/python/tasks/python_binary_create.py b/src/python/pants/backend/python/tasks/python_binary_create.py
@@ -61,8 +61,8 @@ def execute(self):
         else:
           self.context.log.debug('using cache for {}'.format(vt.target))
 
-        python_pex_product.add(binary, os.path.dirname(pex_path)).append(os.path.basename(pex_path))
-        python_deployable_archive.add(binary, os.path.dirname(pex_path)).append(os.path.basename(pex_path))
+        python_pex_product.add(vt.target, os.path.dirname(pex_path)).append(os.path.basename(pex_path))
+        python_deployable_archive.add(vt.target, os.path.dirname(pex_path)).append(os.path.basename(pex_path))
         self.context.log.debug('created {}'.format(os.path.relpath(pex_path, get_buildroot())))
 
         # Create a copy for pex.

diff --git a/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py b/tests/python/pants_test/backend/python/tasks/test_python_binary_create.py
@@ -54,3 +54,11 @@ def _check_products(self, bin_name):
   def test_deployable_archive_products(self):
     self.test_task.execute()
     self._check_products('bin')
+
+  def test_handles_multiple_binary_targets(self):
+    cbin = self.create_python_binary('src/python/cbin', 'cbin', 'lib.lib:main',
+                                     dependencies=['//src/python/lib'])
+    self.task_context = self.context(target_roots=[self.binary, cbin])
+    self.task_context.run_tracker.run_info = RunInfo(self.run_info_dir)
+    self.create_task(self.task_context).execute()
+    self._check_products('bin')