Update the Pants codebase to use register_rules.

[ci skip-rust-tests]

pants-plugins/src/python/internal_backend/rules_for_testing/register.py

@@ -4,7 +4,7 @@
 from pants.engine.addresses import Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 
 
 class ListAndDieForTestingSubsystem(GoalSubsystem):
@@ -25,4 +25,4 @@ def fast_list_and_die_for_testing(console: Console, addresses: Addresses) -> Lis
 
 
 def rules():
-    return [fast_list_and_die_for_testing]
+    return register_rules()

src/python/pants/backend/awslambda/common/awslambda_common_rules.py

@@ -9,7 +9,7 @@
 from pants.engine.console import Console
 from pants.engine.fs import Digest, MergeDigests, Workspace
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSet, TargetsToValidFieldSets, TargetsToValidFieldSetsRequest
 from pants.engine.unions import union
@@ -79,4 +79,4 @@ async def create_awslambda(
 
 
 def rules():
-    return [create_awslambda]
+    return register_rules()

src/python/pants/backend/awslambda/python/awslambda_python_rules.py

@@ -30,7 +30,7 @@
 from pants.core.util_rules import strip_source_roots
 from pants.engine.fs import Digest, MergeDigests
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get
 from pants.engine.unions import UnionRule
 from pants.python.python_setup import PythonSetup
@@ -129,10 +129,8 @@ async def setup_lambdex(lambdex: Lambdex) -> LambdexSetup:
 
 def rules():
     return [
-        create_python_awslambda,
-        setup_lambdex,
+        *register_rules(),
         UnionRule(AWSLambdaFieldSet, PythonAwsLambdaFieldSet),
-        SubsystemRule(Lambdex),
         *download_pex_bin.rules(),
         *python_sources.rules(),
         *pex.rules(),

src/python/pants/backend/codegen/protobuf/python/rules.py

@@ -11,7 +11,7 @@
 from pants.engine.fs import AddPrefix, Digest, MergeDigests, RemovePrefix, Snapshot
 from pants.engine.platform import Platform
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import GeneratedSources, GenerateSourcesRequest, Sources, TransitiveTargets
 from pants.engine.unions import UnionRule
@@ -121,7 +121,6 @@ async def generate_python_from_protobuf(
 
 def rules():
     return [
-        generate_python_from_protobuf,
+        *register_rules(),
         UnionRule(GenerateSourcesRequest, GeneratePythonFromProtobufRequest),
-        SubsystemRule(Protoc),
     ]

src/python/pants/backend/codegen/protobuf/target_types.py

@@ -3,7 +3,7 @@
 
 from pants.backend.codegen.protobuf.protoc import Protoc
 from pants.engine.addresses import Address
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.target import (
     COMMON_TARGET_FIELDS,
     Dependencies,
@@ -51,7 +51,6 @@ def inject_dependencies(_: InjectProtobufDependencies, protoc: Protoc) -> Inject
 
 def rules():
     return [
-        inject_dependencies,
+        *register_rules(),
         UnionRule(InjectDependenciesRequest, InjectProtobufDependencies),
-        SubsystemRule(Protoc),
     ]

src/python/pants/backend/pants_info/list_target_types.py

@@ -8,7 +8,7 @@
 from pants.core.util_rules.pants_bin import PantsBin
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.target import (
     AsyncField,
     BoolField,
@@ -249,4 +249,4 @@ def list_target_types(
 
 
 def rules():
-    return [list_target_types]
+    return register_rules()

src/python/pants/backend/project_info/cloc.py

@@ -20,7 +20,7 @@
 from pants.engine.goal import Goal, GoalSubsystem
 from pants.engine.platform import Platform
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import SubsystemRule, goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get
 from pants.util.strutil import pluralize
 
@@ -131,7 +131,4 @@ async def run_cloc(
 
 
 def rules():
-    return [
-        run_cloc,
-        SubsystemRule(ClocBinary),
-    ]
+    return register_rules()

src/python/pants/backend/project_info/dependees.py

@@ -12,7 +12,7 @@
 from pants.engine.collection import DeduplicatedCollection
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, rule
+from pants.engine.rules import goal_rule, register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import Dependencies, DependenciesRequest, Targets
 from pants.util.frozendict import FrozenDict
@@ -182,4 +182,4 @@ async def dependees_goal(
 
 
 def rules():
-    return [find_dependees, map_addresses_to_dependees, dependees_goal]
+    return register_rules()

src/python/pants/backend/project_info/dependencies.py

@@ -9,7 +9,7 @@
 from pants.engine.addresses import Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import Dependencies as DependenciesField
 from pants.engine.target import DependenciesRequest, Targets, TransitiveTargets
@@ -104,4 +104,4 @@ async def dependencies(
 
 
 def rules():
-    return [dependencies]
+    return register_rules()

src/python/pants/backend/project_info/filedeps.py

@@ -9,7 +9,7 @@
 from pants.engine.addresses import Address, Addresses, BuildFileAddress
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -120,4 +120,4 @@ async def file_deps(
 
 
 def rules():
-    return [file_deps]
+    return register_rules()

src/python/pants/backend/project_info/filter_targets.py

@@ -8,7 +8,7 @@
 from pants.base.deprecated import resolve_conflicting_options
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.target import (
     RegisteredTargetTypes,
     Tags,
@@ -162,4 +162,4 @@ def filter_tag_regex(tag_regex: str) -> TargetFilter:
 
 
 def rules():
-    return [filter_targets]
+    return register_rules()

src/python/pants/backend/project_info/list_roots.py

@@ -3,7 +3,7 @@
 
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.source.source_root import AllSourceRoots
 
 
@@ -28,4 +28,4 @@ async def list_roots(
 
 
 def rules():
-    return [list_roots]
+    return register_rules()

src/python/pants/backend/project_info/list_targets.py

@@ -6,7 +6,7 @@
 from pants.engine.addresses import Address, Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get
 from pants.engine.target import DescriptionField, ProvidesField, Targets
 
@@ -111,4 +111,4 @@ async def list_targets(
 
 
 def rules():
-    return [list_targets]
+    return register_rules()

src/python/pants/backend/project_info/source_file_validator.py

@@ -12,7 +12,7 @@
 from pants.engine.console import Console
 from pants.engine.fs import Digest, DigestContents, SourcesSnapshot
 from pants.engine.goal import Goal, GoalSubsystem
-from pants.engine.rules import SubsystemRule, goal_rule
+from pants.engine.rules import goal_rule, register_rules
 from pants.engine.selectors import Get
 from pants.subsystem.subsystem import Subsystem
 from pants.util.frozendict import FrozenDict
@@ -334,4 +334,4 @@ async def validate(
 
 
 def rules():
-    return [validate, SubsystemRule(SourceFileValidation)]
+    return register_rules()

src/python/pants/backend/python/dependency_inference/module_mapper.py

@@ -12,7 +12,7 @@
     StripSourcesFieldRequest,
 )
 from pants.engine.addresses import Address
-from pants.engine.rules import rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -166,8 +166,4 @@ async def map_module_to_address(
 
 
 def rules():
-    return [
-        map_first_party_modules_to_addresses,
-        map_third_party_modules_to_addresses,
-        map_module_to_address,
-    ]
+    return register_rules()

src/python/pants/backend/python/dependency_inference/rules.py

@@ -16,7 +16,7 @@
 )
 from pants.engine.fs import Digest, DigestContents
 from pants.engine.internals.graph import Owners, OwnersRequest
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -158,13 +158,10 @@ async def infer_python_conftest_dependencies(
 
 def rules():
     return [
+        *register_rules(),
         *inject_ancestor_files.rules(),
         *module_mapper.rules(),
-        infer_python_dependencies,
-        infer_python_init_dependencies,
-        infer_python_conftest_dependencies,
         UnionRule(InferDependenciesRequest, InferPythonDependencies),
         UnionRule(InferDependenciesRequest, InferInitDependencies),
         UnionRule(InferDependenciesRequest, InferConftestDependencies),
-        SubsystemRule(PythonInference),
     ]

src/python/pants/backend/python/lint/bandit/rules.py

@@ -24,7 +24,7 @@
 )
 from pants.engine.fs import Digest, MergeDigests, PathGlobs
 from pants.engine.process import FallibleProcessResult, Process
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -153,9 +153,7 @@ async def bandit_lint(
 
 def rules():
     return [
-        bandit_lint,
-        bandit_lint_partition,
-        SubsystemRule(Bandit),
+        *register_rules(),
         UnionRule(LintRequest, BanditRequest),
         *download_pex_bin.rules(),
         *determine_source_files.rules(),

src/python/pants/backend/python/lint/black/rules.py

@@ -28,7 +28,7 @@
 )
 from pants.engine.fs import EMPTY_SNAPSHOT, Digest, MergeDigests, PathGlobs
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -189,10 +189,7 @@ async def black_lint(field_sets: BlackRequest, black: Black) -> LintResults:
 
 def rules():
     return [
-        setup,
-        black_fmt,
-        black_lint,
-        SubsystemRule(Black),
+        *register_rules(),
         UnionRule(PythonFmtRequest, BlackRequest),
         UnionRule(LintRequest, BlackRequest),
         *download_pex_bin.rules(),

src/python/pants/backend/python/lint/docformatter/rules.py

@@ -26,7 +26,7 @@
 )
 from pants.engine.fs import EMPTY_SNAPSHOT, Digest, MergeDigests
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -162,10 +162,7 @@ async def docformatter_lint(
 
 def rules():
     return [
-        setup,
-        docformatter_fmt,
-        docformatter_lint,
-        SubsystemRule(Docformatter),
+        *register_rules(),
         UnionRule(PythonFmtRequest, DocformatterRequest),
         UnionRule(LintRequest, DocformatterRequest),
         *download_pex_bin.rules(),

src/python/pants/backend/python/lint/flake8/rules.py

@@ -30,7 +30,7 @@
 )
 from pants.engine.fs import Digest, DigestSubset, MergeDigests, PathGlobs, Snapshot
 from pants.engine.process import FallibleProcessResult, Process
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -184,9 +184,7 @@ async def flake8_lint(
 
 def rules():
     return [
-        flake8_lint,
-        flake8_lint_partition,
-        SubsystemRule(Flake8),
+        *register_rules(),
         UnionRule(LintRequest, Flake8Request),
         *download_pex_bin.rules(),
         *determine_source_files.rules(),

src/python/pants/backend/python/lint/flake8/rules_integration_test.py

@@ -7,10 +7,10 @@
 from pants.backend.python.lint.flake8.rules import rules as flake8_rules
 from pants.backend.python.target_types import PythonInterpreterCompatibility, PythonLibrary
 from pants.base.specs import FilesystemLiteralSpec, OriginSpec, SingleAddress
-from pants.core.goals.lint import LintResults, LintSubsystem
+from pants.core.goals.lint import LintResults
 from pants.engine.addresses import Address
 from pants.engine.fs import DigestContents, FileContent
-from pants.engine.rules import RootRule, SubsystemRule
+from pants.engine.rules import RootRule
 from pants.engine.selectors import Params
 from pants.engine.target import TargetWithOrigin
 from pants.testutil.external_tool_test_base import ExternalToolTestBase
@@ -30,7 +30,6 @@ def rules(cls):
             *super().rules(),
             *flake8_rules(),
             RootRule(Flake8Request),
-            SubsystemRule(LintSubsystem),
         )
 
     def make_target_with_origin(

src/python/pants/backend/python/lint/isort/rules.py

@@ -26,7 +26,7 @@
 )
 from pants.engine.fs import EMPTY_SNAPSHOT, Digest, MergeDigests, PathGlobs
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import SubsystemRule, rule
+from pants.engine.rules import register_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -187,10 +187,7 @@ async def isort_lint(request: IsortRequest, isort: Isort) -> LintResults:
 
 def rules():
     return [
-        setup,
-        isort_fmt,
-        isort_lint,
-        SubsystemRule(Isort),
+        *register_rules(),
         UnionRule(PythonFmtRequest, IsortRequest),
         UnionRule(LintRequest, IsortRequest),
         *download_pex_bin.rules(),