Skip to content

Commit

Permalink
remove completed TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
cosmicexplorer committed Nov 26, 2018
1 parent 14ca207 commit 1bd8a47
Showing 1 changed file with 1 addition and 2 deletions.
Expand Up @@ -62,8 +62,6 @@ def test_ctypes_binary_creation(self):
}

def _assert_ctypes_binary(self, toolchain_variant):
# TODO: figure out a way to check that when we select 'gnu' as the `toolchain_variant`, we use
# gcc to compile the C/C++ targets -- the same for 'llvm' and clang.
with temporary_dir() as tmp_dir:
pants_run = self.run_pants(command=['binary', self._binary_target], config={
GLOBAL_SCOPE_CONFIG_SECTION: {
Expand All @@ -81,6 +79,7 @@ def _assert_ctypes_binary(self, toolchain_variant):
for compiler_name in self._compiler_names_for_variant[toolchain_variant]:
self.assertIn("selected compiler exe name: '{}'".format(compiler_name),
pants_run.stdout_data)

for linker_name in self._linker_names_for_variant[toolchain_variant]:
self.assertIn("selected linker exe name: '{}'".format(linker_name),
pants_run.stdout_data)
Expand Down

0 comments on commit 1bd8a47

Please sign in to comment.