Skip to content

Commit

Permalink
Remove targets goal in favor of target-types goal (#10145)
Browse files Browse the repository at this point in the history
`target-types` is a better name and has more descriptive information thanks to the Target API.

[ci skip-rust-tests]
[ci skip-jvm-tests]
  • Loading branch information
Eric-Arellano committed Jun 24, 2020
1 parent 0ebbeb0 commit 23b5ce5
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 601 deletions.
2 changes: 0 additions & 2 deletions src/python/pants/core_tasks/register.py
Expand Up @@ -17,7 +17,6 @@
RunTestPrepCommand,
)
from pants.core_tasks.substitute_aliased_targets import SubstituteAliasedTargets
from pants.core_tasks.targets_help import TargetsHelp
from pants.goal.goal import Goal
from pants.goal.task_registrar import TaskRegistrar as task

Expand Down Expand Up @@ -59,7 +58,6 @@ def register_goals():

# Getting help.
task(name="options", action=ExplainOptionsTask).install()
task(name="targets", action=TargetsHelp).install()

# Stub for other goals to schedule 'compile'. See noop_exec_task.py for why this is useful.
task(name="compile", action=NoopCompile).install("compile")
Expand Down
41 changes: 0 additions & 41 deletions src/python/pants/core_tasks/targets_help.py

This file was deleted.

13 changes: 7 additions & 6 deletions src/python/pants/help/BUILD
Expand Up @@ -3,16 +3,17 @@

python_library(
dependencies=[
'3rdparty/python:ansicolors',
'3rdparty/python:dataclasses',
'3rdparty/python:typing-extensions',
'src/python/pants/base:build_environment',
'src/python/pants/base:exceptions',
'src/python/pants/build_graph',
'src/python/pants/base:deprecated',
'src/python/pants/engine:goal',
'src/python/pants/engine:unions',
'src/python/pants/goal',
'src/python/pants/option:global_options',
'src/python/pants/option',
'src/python/pants/subsystem',
'src/python/pants/util:memo',
],
tags = {"partially_type_checked"},
)
Expand All @@ -21,10 +22,10 @@ python_tests(
name='tests',
sources=['*_test.py', '!*_integration_test.py'],
dependencies=[
'src/python/pants/engine/internals:native',
'src/python/pants/build_graph',
'src/python/pants/help',
':help',
'3rdparty/python:dataclasses',
'src/python/pants/option',
'src/python/pants/option:global_options',
'src/python/pants/subsystem',
'src/python/pants/task',
],
Expand Down
277 changes: 0 additions & 277 deletions src/python/pants/help/build_dictionary_info_extracter.py

This file was deleted.

0 comments on commit 23b5ce5

Please sign in to comment.