Merge ea19c80 into 391d468

pantsbuild · Sep 13, 2020 · 28d9c92 · 28d9c92
2 parents 391d468 + ea19c80
commit 28d9c92
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/python/pants/engine/desktop.py b/src/python/pants/engine/desktop.py
@@ -57,7 +57,13 @@ async def find_open_program(request: OpenFilesRequest, plat: Platform) -> OpenFi
     else:
         processes = [
             InteractiveProcess(
-                argv=(open_program_paths.first_path.path, str(f)), run_in_workspace=True
+                argv=(open_program_paths.first_path.path, str(f)),
+                run_in_workspace=True,
+                # The xdg-open binary needs many environment variables to work properly. In addition
+                # to the various XDG_* environment variables, DISPLAY and other X11 variables are
+                # required. Instead of attempting to track all of these we just export the full user
+                # environment since this is not a cached process.
+                hermetic_env=False,
             )
             for f in request.files
         ]