Skip to content

Commit

Permalink
Fix two failing tests
Browse files Browse the repository at this point in the history
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
  • Loading branch information
Eric-Arellano committed Aug 23, 2020
1 parent ea4cb31 commit 34f863c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion tests/python/pants_test/bin/loader_integration_test.py
Expand Up @@ -24,7 +24,7 @@ def test_alternate_entrypoint() -> None:
pants_run = run_pants(
command=["help"], extra_env={"PANTS_ENTRYPOINT": "pants.bin.pants_exe:test"}
)
pants_run.assert_failure()
pants_run.assert_success()
assert "T E S T" in pants_run.stdout


Expand Down
3 changes: 0 additions & 3 deletions tests/python/pants_test/logging/BUILD
Expand Up @@ -2,9 +2,6 @@
# Licensed under the Apache License, Version 2.0 (see LICENSE).

python_integration_tests(
name='tests',
uses_pants_run=True,
timeout=150,
)

python_library()
Expand Up @@ -9,11 +9,15 @@

def test_native_logging() -> None:
expected_msg = r"\[DEBUG\] Launching \d+ root"
pants_run = run_pants(["-linfo", "list", "3rdparty::"])
pants_run = run_pants(
["-linfo", "--backend-packages=pants.backend.python", "list", "3rdparty::"]
)
pants_run.assert_success()
assert not bool(re.search(expected_msg, pants_run.stderr))

pants_run = run_pants(["-ldebug", "list", "3rdparty::"])
pants_run = run_pants(
["-ldebug", "--backend-packages=pants.backend.python", "list", "3rdparty::"]
)
pants_run.assert_success()
assert bool(re.search(expected_msg, pants_run.stderr))

Expand Down

0 comments on commit 34f863c

Please sign in to comment.