Rename register_rules to collect_rules.

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]

pants-plugins/src/python/internal_backend/rules_for_testing/register.py

@@ -4,7 +4,7 @@
 from pants.engine.addresses import Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 
 
 class ListAndDieForTestingSubsystem(GoalSubsystem):
@@ -25,4 +25,4 @@ def fast_list_and_die_for_testing(console: Console, addresses: Addresses) -> Lis
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/awslambda/common/awslambda_common_rules.py

@@ -9,7 +9,7 @@
 from pants.engine.console import Console
 from pants.engine.fs import Digest, MergeDigests, Workspace
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSet, TargetsToValidFieldSets, TargetsToValidFieldSetsRequest
 from pants.engine.unions import union
@@ -79,4 +79,4 @@ async def create_awslambda(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/awslambda/python/awslambda_python_rules.py

@@ -30,7 +30,7 @@
 from pants.core.util_rules import strip_source_roots
 from pants.engine.fs import Digest, MergeDigests
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get
 from pants.engine.unions import UnionRule
 from pants.python.python_setup import PythonSetup
@@ -129,7 +129,7 @@ async def setup_lambdex(lambdex: Lambdex) -> LambdexSetup:
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(AWSLambdaFieldSet, PythonAwsLambdaFieldSet),
         *download_pex_bin.rules(),
         *python_sources.rules(),

src/python/pants/backend/codegen/protobuf/python/rules.py

@@ -11,7 +11,7 @@
 from pants.engine.fs import AddPrefix, Digest, MergeDigests, RemovePrefix, Snapshot
 from pants.engine.platform import Platform
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import GeneratedSources, GenerateSourcesRequest, Sources, TransitiveTargets
 from pants.engine.unions import UnionRule
@@ -121,6 +121,6 @@ async def generate_python_from_protobuf(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(GenerateSourcesRequest, GeneratePythonFromProtobufRequest),
     ]

src/python/pants/backend/codegen/protobuf/target_types.py

@@ -3,7 +3,7 @@
 
 from pants.backend.codegen.protobuf.protoc import Protoc
 from pants.engine.addresses import Address
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.target import (
     COMMON_TARGET_FIELDS,
     Dependencies,
@@ -51,6 +51,6 @@ def inject_dependencies(_: InjectProtobufDependencies, protoc: Protoc) -> Inject
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(InjectDependenciesRequest, InjectProtobufDependencies),
     ]

src/python/pants/backend/pants_info/list_target_types.py

@@ -8,7 +8,7 @@
 from pants.core.util_rules.pants_bin import PantsBin
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.target import (
     AsyncField,
     BoolField,
@@ -249,4 +249,4 @@ def list_target_types(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/cloc.py

@@ -20,7 +20,7 @@
 from pants.engine.goal import Goal, GoalSubsystem
 from pants.engine.platform import Platform
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get
 from pants.util.strutil import pluralize
 
@@ -131,4 +131,4 @@ async def run_cloc(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/dependees.py

@@ -12,7 +12,7 @@
 from pants.engine.collection import DeduplicatedCollection
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules, rule
+from pants.engine.rules import collect_rules, goal_rule, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import Dependencies, DependenciesRequest, Targets
 from pants.util.frozendict import FrozenDict
@@ -182,4 +182,4 @@ async def dependees_goal(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/dependencies.py

@@ -9,7 +9,7 @@
 from pants.engine.addresses import Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import Dependencies as DependenciesField
 from pants.engine.target import DependenciesRequest, Targets, TransitiveTargets
@@ -104,4 +104,4 @@ async def dependencies(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/filedeps.py

@@ -9,7 +9,7 @@
 from pants.engine.addresses import Address, Addresses, BuildFileAddress
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -120,4 +120,4 @@ async def file_deps(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/filter_targets.py

@@ -8,7 +8,7 @@
 from pants.base.deprecated import resolve_conflicting_options
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.target import (
     RegisteredTargetTypes,
     Tags,
@@ -162,4 +162,4 @@ def filter_tag_regex(tag_regex: str) -> TargetFilter:
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/list_roots.py

@@ -3,7 +3,7 @@
 
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.source.source_root import AllSourceRoots
 
 
@@ -28,4 +28,4 @@ async def list_roots(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/list_targets.py

@@ -6,7 +6,7 @@
 from pants.engine.addresses import Address, Addresses
 from pants.engine.console import Console
 from pants.engine.goal import Goal, GoalSubsystem, LineOriented
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get
 from pants.engine.target import DescriptionField, ProvidesField, Targets
 
@@ -111,4 +111,4 @@ async def list_targets(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/project_info/source_file_validator.py

@@ -12,7 +12,7 @@
 from pants.engine.console import Console
 from pants.engine.fs import Digest, DigestContents, SourcesSnapshot
 from pants.engine.goal import Goal, GoalSubsystem
-from pants.engine.rules import goal_rule, register_rules
+from pants.engine.rules import collect_rules, goal_rule
 from pants.engine.selectors import Get
 from pants.subsystem.subsystem import Subsystem
 from pants.util.frozendict import FrozenDict
@@ -334,4 +334,4 @@ async def validate(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/python/dependency_inference/module_mapper.py

@@ -12,7 +12,7 @@
     StripSourcesFieldRequest,
 )
 from pants.engine.addresses import Address
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -166,4 +166,4 @@ async def map_module_to_address(
 
 
 def rules():
-    return register_rules()
+    return collect_rules()

src/python/pants/backend/python/dependency_inference/rules.py

@@ -16,7 +16,7 @@
 )
 from pants.engine.fs import Digest, DigestContents
 from pants.engine.internals.graph import Owners, OwnersRequest
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     HydratedSources,
@@ -158,7 +158,7 @@ async def infer_python_conftest_dependencies(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         *inject_ancestor_files.rules(),
         *module_mapper.rules(),
         UnionRule(InferDependenciesRequest, InferPythonDependencies),

src/python/pants/backend/python/lint/bandit/rules.py

@@ -24,7 +24,7 @@
 )
 from pants.engine.fs import Digest, GlobMatchErrorBehavior, MergeDigests, PathGlobs
 from pants.engine.process import FallibleProcessResult, Process
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -152,7 +152,7 @@ async def bandit_lint(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(LintRequest, BanditRequest),
         *download_pex_bin.rules(),
         *determine_source_files.rules(),

src/python/pants/backend/python/lint/black/rules.py

@@ -28,7 +28,7 @@
 )
 from pants.engine.fs import EMPTY_SNAPSHOT, Digest, GlobMatchErrorBehavior, MergeDigests, PathGlobs
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -188,7 +188,7 @@ async def black_lint(field_sets: BlackRequest, black: Black) -> LintResults:
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(PythonFmtRequest, BlackRequest),
         UnionRule(LintRequest, BlackRequest),
         *download_pex_bin.rules(),

src/python/pants/backend/python/lint/docformatter/rules.py

@@ -26,7 +26,7 @@
 )
 from pants.engine.fs import EMPTY_SNAPSHOT, Digest, MergeDigests
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -162,7 +162,7 @@ async def docformatter_lint(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(PythonFmtRequest, DocformatterRequest),
         UnionRule(LintRequest, DocformatterRequest),
         *download_pex_bin.rules(),

src/python/pants/backend/python/lint/flake8/rules.py

@@ -37,7 +37,7 @@
     Snapshot,
 )
 from pants.engine.process import FallibleProcessResult, Process
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -190,7 +190,7 @@ async def flake8_lint(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(LintRequest, Flake8Request),
         *download_pex_bin.rules(),
         *determine_source_files.rules(),

src/python/pants/backend/python/lint/isort/rules.py

@@ -33,7 +33,7 @@
     PathGlobs,
 )
 from pants.engine.process import FallibleProcessResult, Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import FieldSetWithOrigin
 from pants.engine.unions import UnionRule
@@ -192,7 +192,7 @@ async def isort_lint(request: IsortRequest, isort: Isort) -> LintResults:
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(PythonFmtRequest, IsortRequest),
         UnionRule(LintRequest, IsortRequest),
         *download_pex_bin.rules(),

src/python/pants/backend/python/lint/pylint/rules.py

@@ -40,7 +40,7 @@
     PathGlobs,
 )
 from pants.engine.process import FallibleProcessResult, Process
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import (
     Dependencies,
@@ -310,7 +310,7 @@ async def pylint_lint(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(LintRequest, PylintRequest),
         *download_pex_bin.rules(),
         *determine_source_files.rules(),

src/python/pants/backend/python/lint/python_fmt.py

@@ -9,7 +9,7 @@
 from pants.core.goals.style_request import StyleRequest
 from pants.core.util_rules.determine_source_files import AllSourceFilesRequest, SourceFiles
 from pants.engine.fs import Digest, Snapshot
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get
 from pants.engine.unions import UnionMembership, UnionRule, union
 
@@ -66,4 +66,4 @@ async def format_python_target(
 
 
 def rules():
-    return [*register_rules(), UnionRule(LanguageFmtTargets, PythonFmtTargets)]
+    return [*collect_rules(), UnionRule(LanguageFmtTargets, PythonFmtTargets)]

src/python/pants/backend/python/rules/coverage.py

@@ -40,7 +40,7 @@
     PathGlobs,
 )
 from pants.engine.process import Process, ProcessResult
-from pants.engine.rules import register_rules, rule
+from pants.engine.rules import collect_rules, rule
 from pants.engine.selectors import Get, MultiGet
 from pants.engine.target import TransitiveTargets
 from pants.engine.unions import UnionRule
@@ -335,6 +335,6 @@ def _get_coverage_reports(
 
 def rules():
     return [
-        *register_rules(),
+        *collect_rules(),
         UnionRule(CoverageDataCollection, PytestCoverageDataCollection),
     ]