Skip to content

Commit

Permalink
Fix invalid type checks.
Browse files Browse the repository at this point in the history
  • Loading branch information
stuhood committed Jun 1, 2019
1 parent d118426 commit 847758e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/python/pants_test/pants_run_integration_test.py
Expand Up @@ -23,7 +23,7 @@
from pants.subsystem.subsystem import Subsystem
from pants.util.contextutil import environment_as, pushd, temporary_dir
from pants.util.dirutil import fast_relpath, safe_mkdir, safe_mkdir_for, safe_open
from pants.util.objects import Exactly, datatype, string_list, string_type
from pants.util.objects import Exactly, datatype, string_type
from pants.util.osutil import IntegerForPid
from pants.util.process_handler import SubprocessProcessHandler, subprocess
from pants.util.py2_compat import configparser
Expand All @@ -32,7 +32,8 @@


class PantsResult(datatype([
('command', string_list),
# NB: May be either a string list or string (in the case of `shell=True`).
'command',
('returncode', int),
('stdout_data', string_type),
('stderr_data', string_type),
Expand All @@ -43,7 +44,8 @@ class PantsResult(datatype([


class PantsJoinHandle(datatype([
('command', string_list),
# NB: May be either a string list or string (in the case of `shell=True`).
'command',
'process',
('workdir', string_type),
])):
Expand Down Expand Up @@ -385,7 +387,6 @@ def run_pants(self, command, config=None, stdin_data=None, extra_env=None, clean
:param list command: A list of command line arguments coming after `./pants`.
:param config: Optional data for a generated ini file. A map of <section-name> ->
map of key -> value. If order in the ini file matters, this should be an OrderedDict.
# TODO: ???
:param kwargs: Extra keyword args to pass to `subprocess.Popen`.
:returns a PantsResult instance.
"""
Expand Down Expand Up @@ -619,7 +620,6 @@ def do_command(self, *args, **kwargs):
"""Wrapper around run_pants method.
:param args: command line arguments used to run pants
# TODO: ???
:return: a PantsResult object
"""
cmd = list(args)
Expand Down

0 comments on commit 847758e

Please sign in to comment.