Remove v1 Java Protobuf implementation (#10111)

1.30.x is expected to be the last release in the Pants 1.x series. Pants 2.x will no longer support the v1 engine, meaning this backend will no longer work. For anyone who still needs this functionality, we will give instructions and a script for users to be able to keep using Pants 1.x and Pants 2.x side-by-side. After we add a v2 Java implementation and given enough user interest, we can also port this functionality to the v2 engine or help users to write a plugin. [ci skip-rust-tests] [ci skip-jvm-tests]
pantsbuild · Jun 21, 2020 · c7b1db6 · c7b1db6
1 parent 49eb34b
commit c7b1db6
Show file tree

Hide file tree

Showing 74 changed files with 10 additions and 1,402 deletions.
diff --git a/examples/3rdparty/python/requirements.txt b/examples/3rdparty/python/requirements.txt
@@ -1,3 +1,2 @@
-protobuf==3.6.1
 tensorflow==1.14.0
 thrift>=0.10.0
diff --git a/examples/src/java/org/pantsbuild/example/BUILD b/examples/src/java/org/pantsbuild/example/BUILD
@@ -10,7 +10,6 @@ target(
     ':java_sources_directory',
     ':javac_directory',
     ':make_it_rain_directory',
-    ':protobuf_directory',
     # NB: See `:java_sources_directory` for why we must declare this dependency here.
     'examples/src/scala/org/pantsbuild/example:scala_with_java_sources_directory'
   ],
@@ -106,13 +105,3 @@ files(
     'examples/src/thrift/org/pantsbuild/example:precipitation_directory',
   ],
 )
-
-files(
-  name = 'protobuf_directory',
-  sources = ['protobuf/**/*'],
-  dependencies = [
-    'examples/src/protobuf/org/pantsbuild/example:distance_directory',
-    'examples/src/protobuf/org/pantsbuild/example:imports_directory',
-    'examples/src/protobuf/org/pantsbuild/example:unpacked_jars_directory',
-  ],
-)
diff --git a/examples/src/java/org/pantsbuild/example/protobuf/distance/BUILD b/examples/src/java/org/pantsbuild/example/protobuf/distance/BUILD
diff --git a/examples/src/java/org/pantsbuild/example/protobuf/distance/ExampleProtobuf.java b/examples/src/java/org/pantsbuild/example/protobuf/distance/ExampleProtobuf.java
diff --git a/examples/src/java/org/pantsbuild/example/protobuf/imports/BUILD b/examples/src/java/org/pantsbuild/example/protobuf/imports/BUILD
diff --git a/examples/src/java/org/pantsbuild/example/protobuf/imports/ExampleProtobufImports.java b/examples/src/java/org/pantsbuild/example/protobuf/imports/ExampleProtobufImports.java
diff --git a/examples/src/java/org/pantsbuild/example/protobuf/unpacked_jars/BUILD b/examples/src/java/org/pantsbuild/example/protobuf/unpacked_jars/BUILD
diff --git a/...rc/java/org/pantsbuild/example/protobuf/unpacked_jars/ExampleProtobufExternalArchive.java b/...rc/java/org/pantsbuild/example/protobuf/unpacked_jars/ExampleProtobufExternalArchive.java
diff --git a/examples/src/protobuf/org/pantsbuild/example/BUILD b/examples/src/protobuf/org/pantsbuild/example/BUILD
diff --git a/examples/src/protobuf/org/pantsbuild/example/distance/BUILD b/examples/src/protobuf/org/pantsbuild/example/distance/BUILD
diff --git a/examples/src/protobuf/org/pantsbuild/example/distance/distances.proto b/examples/src/protobuf/org/pantsbuild/example/distance/distances.proto
diff --git a/examples/src/protobuf/org/pantsbuild/example/imports/BUILD b/examples/src/protobuf/org/pantsbuild/example/imports/BUILD
diff --git a/examples/src/protobuf/org/pantsbuild/example/imports/test_imports.proto b/examples/src/protobuf/org/pantsbuild/example/imports/test_imports.proto
diff --git a/examples/src/protobuf/org/pantsbuild/example/unpacked_jars/BUILD b/examples/src/protobuf/org/pantsbuild/example/unpacked_jars/BUILD
diff --git a/examples/tests/java/org/pantsbuild/example/BUILD b/examples/tests/java/org/pantsbuild/example/BUILD
@@ -5,8 +5,6 @@ target(
   name = 'all_directories',
   dependencies = [
     ':hello_directory',
-    ':useproto_directory',
-    ':useprotoimports_directory',
     ':usethrift_directory',
   ],
 )
@@ -20,22 +18,6 @@ files(
   ],
 )
 
-files(
-  name = 'useproto_directory',
-  sources = ['useproto/**/*'],
-  dependencies = [
-    'examples/src/protobuf/org/pantsbuild/example:distance_directory',
-  ],
-)
-
-files(
-  name = 'useprotoimports_directory',
-  sources = ['useprotoimports/**/*'],
-  dependencies = [
-    'examples/src/protobuf/org/pantsbuild/example:imports_directory',
-  ],
-)
-
 files(
   name = 'usethrift_directory',
   sources = ['usethrift/**/*'],

diff --git a/examples/tests/java/org/pantsbuild/example/useproto/BUILD b/examples/tests/java/org/pantsbuild/example/useproto/BUILD
diff --git a/examples/tests/java/org/pantsbuild/example/useproto/UseProtoTest.java b/examples/tests/java/org/pantsbuild/example/useproto/UseProtoTest.java
diff --git a/examples/tests/java/org/pantsbuild/example/useprotoimports/BUILD b/examples/tests/java/org/pantsbuild/example/useprotoimports/BUILD
diff --git a/examples/tests/java/org/pantsbuild/example/useprotoimports/UseImportsTest.java b/examples/tests/java/org/pantsbuild/example/useprotoimports/UseImportsTest.java
diff --git a/pants.toml b/pants.toml
@@ -229,9 +229,6 @@ config = "%(buildroot)s/build-support/scalastyle/scalastyle_config.xml"
 [lint.scalastyle]
 excludes = "%(buildroot)s/build-support/scalastyle/excludes.txt"
 
-[protoc]
-version = "2.4.1"
-
 [scala]
 version = 2.12
 

diff --git a/src/python/pants/backend/codegen/BUILD b/src/python/pants/backend/codegen/BUILD
@@ -4,7 +4,6 @@
 python_library(
   name = 'plugin',
   dependencies = [
-    'src/python/pants/backend/codegen/protobuf/java',
     'src/python/pants/backend/codegen/thrift/java',
     'src/python/pants/backend/codegen/thrift/python',
     'src/python/pants/build_graph',

diff --git a/src/python/pants/backend/codegen/protobuf/BUILD b/src/python/pants/backend/codegen/protobuf/BUILD
@@ -3,6 +3,8 @@
 
 python_library(
   dependencies = [
+    'src/python/pants/core/util_rules',
+    'src/python/pants/engine:platform',
     'src/python/pants/engine:target',
   ],
   tags = {"type_checked"},

diff --git a/src/python/pants/backend/codegen/protobuf/java/BUILD b/src/python/pants/backend/codegen/protobuf/java/BUILD
diff --git a/src/python/pants/backend/codegen/protobuf/java/__init__.py b/src/python/pants/backend/codegen/protobuf/java/__init__.py
diff --git a/src/python/pants/backend/codegen/protobuf/java/java_protobuf_library.py b/src/python/pants/backend/codegen/protobuf/java/java_protobuf_library.py