Skip some weird interactions with the hermetic hacks

pantsbuild · Mar 28, 2019 · ccb8c3e · ccb8c3e
1 parent 69d23d7
commit ccb8c3e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/tests/python/pants_test/engine/legacy/test_console_rule_integration.py b/tests/python/pants_test/engine/legacy/test_console_rule_integration.py
@@ -18,11 +18,10 @@
 class TestConsoleRuleIntegration(PantsDaemonIntegrationTestBase):
 
   @ensure_daemon
-#  @skip_if_tests_are_hermetic(
-#    PantsDaemonIntegrationTestBase,
-#    "Will complain about absolute symlinks. And missing plugins"
-#    "This is because of the --pants-config-files=[] that is passed when hermetic."
-#    "The solution is probably to manually insert the relevant configuration on these tests")
+  @skip_if_tests_are_hermetic(
+    PantsDaemonIntegrationTestBase,
+    "Even with the hermetic hacks, this will not go through the pantsd_successful_run() context\n" +
+    "Therefore, it will not have all the packages loaded. Should be fixed when we fix hermetic for good.")
   def test_v2_list(self):
     result = self.do_command(
       '--no-v1',

diff --git a/tests/python/pants_test/pantsd/test_pantsd_integration.py b/tests/python/pants_test/pantsd/test_pantsd_integration.py
@@ -204,6 +204,10 @@ def test_pantsd_stray_runners(self):
         # The runner can sometimes exit more slowly than the thin client caller.
         time.sleep(3)
 
+  @skip_if_tests_are_hermetic(
+    PantsDaemonIntegrationTestBase,
+    "Since we hackily inject all the packages when running hermetically,"
+    "the output of _goals_ doesn't match.")
   def test_pantsd_aligned_output(self):
     # Set for pytest output display.
     self.maxDiff = None