Skip to content

Commit

Permalink
Remove use of "quiet" in logging init (#10417)
Browse files Browse the repository at this point in the history
### Problem

A small bit of code in `init/logging.py` branches based on the value of the "quiet" option, even though this option has been removed.

### Solution

Remove that branching.
  • Loading branch information
gshuflin committed Jul 21, 2020
1 parent 3d96a43 commit ce9e3a0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/python/pants/init/logging.py
Expand Up @@ -128,14 +128,13 @@ def setup_logging(global_bootstrap_options):

ignores = global_bootstrap_options.ignore_pants_warnings
global_level = global_bootstrap_options.level
level = LogLevel.ERROR if getattr(global_bootstrap_options, "quiet", False) else global_level
log_dir = global_bootstrap_options.logdir

log_show_rust_3rdparty = global_bootstrap_options.log_show_rust_3rdparty
use_color = global_bootstrap_options.colors

init_rust_logger(level, log_show_rust_3rdparty, use_color)
setup_logging_to_stderr(level, warnings_filter_regexes=ignores)
init_rust_logger(global_level, log_show_rust_3rdparty, use_color)
setup_logging_to_stderr(global_level, warnings_filter_regexes=ignores)
if log_dir:
setup_logging_to_file(global_level, log_dir=log_dir, warnings_filter_regexes=ignores)

Expand Down

0 comments on commit ce9e3a0

Please sign in to comment.