Skip to content

Commit

Permalink
Fix --print-exception-stacktrace not invalidating pantsd (#10451)
Browse files Browse the repository at this point in the history
Before, if a command failed and you run it again with `--print-exception-stacktrace`, it would make no difference because the daemon's cache was being used.

Now, we force pantsd to restart so that the option works properly.

[ci skip-rust-tests]
  • Loading branch information
Eric-Arellano committed Jul 27, 2020
1 parent 9ca7b52 commit d63b29c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/python/pants/option/global_options.py
Expand Up @@ -572,7 +572,11 @@ def register_bootstrap_options(cls, register):
"--print-exception-stacktrace",
advanced=True,
type=bool,
fingerprint=False,
default=False,
# TODO: We must restart the daemon because of global mutable state in `init/logging.py`
# from `ExceptionSink.should_print_exception_stacktrace`. Fix this and only use
# `fingerprint=True` instead.
daemon=True,
help="Print to console the full exception stack trace if encountered.",
)

Expand Down

0 comments on commit d63b29c

Please sign in to comment.