Skip to content

Commit

Permalink
fix incorrect mapping of parameters into PyRemotingOptions struct (#1…
Browse files Browse the repository at this point in the history
…0752)

### Problem

#10215 refactored how remote execution options were passed from Python to Rust. I introduced a bug in the PR though by incorrectly mapping three of the parameters.

:facepalm: 

The bug manifested as the timeout on blob upload being too low.

### Solution

Map the parameters correctly.

### Result

Upload of larger blobs should not timeout too early.
  • Loading branch information
Tom Dyas committed Sep 9, 2020
1 parent 54b9a79 commit ef92e48
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/python/pants/engine/internals/native.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,9 @@ def new_scheduler(
oauth_bearer_token_path=execution_options.remote_oauth_bearer_token_path,
store_thread_count=execution_options.remote_store_thread_count,
store_chunk_bytes=execution_options.remote_store_chunk_bytes,
store_chunk_upload_timeout=execution_options.remote_store_connection_limit,
store_rpc_retries=execution_options.remote_store_chunk_upload_timeout_seconds,
store_connection_limit=execution_options.remote_store_rpc_retries,
store_chunk_upload_timeout=execution_options.remote_store_chunk_upload_timeout_seconds,
store_rpc_retries=execution_options.remote_store_rpc_retries,
store_connection_limit=execution_options.remote_store_connection_limit,
execution_extra_platform_properties=tuple(
tuple(pair.split("=", 1))
for pair in execution_options.remote_execution_extra_platform_properties
Expand Down

0 comments on commit ef92e48

Please sign in to comment.