Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantsd leaks memory on ubuntu linux box #10264

Closed
asherf opened this issue Jul 6, 2020 · 2 comments · Fixed by #10287
Closed

pantsd leaks memory on ubuntu linux box #10264

asherf opened this issue Jul 6, 2020 · 2 comments · Fixed by #10287
Projects
Pants Daemon

Comments

@asherf
Copy link
Member

asherf commented Jul 6, 2020

We have an EC2 machine running ubuntu
Linux ip-10-1-201-194 5.3.0-1028-aws #30~18.04.1-Ubuntu SMP Mon Jun 22 15:48:21 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Pantsd leaks memory which causes the machine to hang a few times a week.
Screen Shot 2020-07-06 at 8 48 52 AM
Screen Shot 2020-07-06 at 8 49 16 AM

@stuhood FYI
@stuhood
Copy link
Sponsor Member

stuhood commented Jul 6, 2020 •
edited

This was previously resolved in #10003, but it looks like the default value is too high for this box. 4GB still feels like a reasonable default, although we could maybe try to do a better job of choosing it automatically with something like https://crates.io/crates/effective-limits

In this case, it feels like lowering the default in this environment might be reasonable? A shared dev box with 4GB total ram is unusual.

@asherf
Copy link
Member Author

asherf commented Jul 6, 2020

obviously, I don't have enough context. However, as a user, 4gb seems extremely excessive.
so I don't think that is a reasonable default. We need to keep memory free so we can run slack & chrome ;-)

@stuhood stuhood mentioned this issue Jul 7, 2020
Merged
stuhood added a commit that referenced this issue Jul 7, 2020
@stuhood
Lower the default max-memory usage of pantsd. (#10287)
e5eed25 
### Problem

The default max memory usage from #10003 was chosen with larger monorepos in mind, and didn't match the expectation of consumers in smaller repos. 

### Solution

Very large repos will have folks who are able/willing to adjust limits like this to optimize for their repo size, so adjust the default down in favor of having good defaults.  This relates to #7675, but it isn't the time to dive in there.

### Result

Fixes #10264.

[ci skip-rust-tests]
@stuhood stuhood added this to TODO in Pants Daemon via automation Jul 7, 2020
@stuhood stuhood moved this from TODO to Done in Pants Daemon Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Pants Daemon
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lower the default max-memory usage of pantsd. stuhood/pants
2 participants
@stuhood @asherf