JVM: Create separate classes for pre-resolve and post-resolve Coordinate use cases
#13840
Projects
Comments
chrisjrn
pushed a commit
that referenced
this issue
Dec 10, 2021
This adds (working) support for local JAR and URL coordinates at resolve and at fetch time. Summary of changes: * Creates new `ArtifactRequirement` concept, which is used to build up download instructions for Coursier. It stores coordinates, (remote) URLs, and JAR source fields * Adds a new concept called `CoursierResolveInfo`. This contains a list of coordinate (+url) strings and a Digest containing local JAR files * Adds URL and JAR address fields to `CoursierResolvedLockfile` and the relevant serialized format. This is used to ensure that the correct JARs are used at fetch time * Updates `coursier_fetch_one_coord` to use `CoursierResolveInfo` internally Closes #13840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Coordinates inCoursierLockfileEntryare used solely as pointers to other coordinates. Since then, we've addedurland (soon)jar, which is used entirely for inputs intoResolves.These should be split into pre-resolve and post-resolve cases, so that it's easier to test for equality etc in the post-resolve case.
The text was updated successfully, but these errors were encountered: