Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint --skip-formatters #14460

Closed
thejcannon opened this issue Feb 12, 2022 · 2 comments · Fixed by #15427
Closed

lint --skip-formatters #14460

thejcannon opened this issue Feb 12, 2022 · 2 comments · Fixed by #15427
Assignees

Comments

@thejcannon
Copy link
Member

Is your feature request related to a problem? Please describe.
Our current workflow is one CI step for formatters (in check mode) and one for linters. As we roll out Pants, I don't want us to change CI just yet.
As we change formatters (adding removing etc...) it'd be nice to not have to change the pants args each switch.

Describe the solution you'd like
a --skip-formatters flag for lint.

Describe alternatives you've considered
--skip-X and --skip-Y

Additional context
This doesn't have a good "mirror" for "only formatters", as --skip-linters would be ambiguous. It also name squats on "formatters", but I hope that tool name will never need to exists 😂

@charlesoconor
Copy link

This would be awesome I have a script that has to list them out by hand to not run them twice.

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented May 12, 2022

@thejcannon this is now super easy to do thanks to your improvements! I'll try this out right now before lunch :) #15427

@Eric-Arellano Eric-Arellano self-assigned this May 12, 2022
Eric-Arellano added a commit that referenced this issue May 12, 2022
Closes #14460.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants