Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arg-less ./pants tailor deprecation warning confusing for users new to Pants #15868

Closed
danxmoran opened this issue Jun 17, 2022 · 1 comment · Fixed by #15932
Closed

Arg-less ./pants tailor deprecation warning confusing for users new to Pants #15868

danxmoran opened this issue Jun 17, 2022 · 1 comment · Fixed by #15932
Assignees
Labels

Comments

@danxmoran
Copy link
Contributor

Describe the bug

# Create some new source dir
mkdir  src/new_dir
# Create a new file in that dir
echo 'print "hey" > src/new_dir/new_file.py'
# Tailor the file
./pants tailor

The above will print:

Currently, `./pants tailor` without arguments will run against every file in the project.

In Pants 2.14, you must use CLI arguments. Use:

  * `::` to run on everything
  * `dir::` to run on `dir` and subdirs
  * `dir` to run on `dir`

I've gotten feedback from users ~relatively unfamiliar with Pants that they aren't sure what to do about the warning.

I think having something more copy-paste-able might help. Something like:

Currently, `./pants tailor` without arguments will run against every file in the project.

In Pants 2.14, you must use CLI arguments. Use:

  * `./pants tailor ::` to run on everything
  * `./pants tailor dir::` to run on `dir` and subdirs
  * `./pants tailor dir` to run on `dir`

Pants version

PANTS_SHA=19fe4e3cec21067791dea8f1351c033c7132f579

OS

Both

@danxmoran danxmoran added the bug label Jun 17, 2022
@Eric-Arellano Eric-Arellano self-assigned this Jun 24, 2022
@Eric-Arellano
Copy link
Contributor

Great suggestion! Thanks!

Eric-Arellano added a commit that referenced this issue Jun 24, 2022
Eric-Arellano added a commit to Eric-Arellano/pants that referenced this issue Jun 24, 2022
…quiring CLI arguments (pantsbuild#15932)

Closes pantsbuild#15868.

[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this issue Jun 25, 2022
…quiring CLI arguments (Cherry-pick of #15932) (#15937)

Closes #15868.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants