-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other top-level gitignore locations #15935
Comments
Great idea! I added this to the Onboarding project and label. Fixing this means it's more likely Pants will Just Work on a new repo, which is an important goal for Pantsbuild. |
Would you have any interest in implementing this? We'd be happy to try to scope out how this would work. It would involve writing some Rust code. |
Semi-relevant Slack thread example today: Summary: Bastian changed his However, when using this set of ignores: pants_ignore.add = [
"/apps/",
"/src/bin",
"/src/docker",
"/frontend/",
"/python/",
".idea/",
"*.md",
] This was popping up in the log: Because the tilde temp file wasn't in the On my machine, all of these temp files are excluded directly from my |
Is your feature request related to a problem? Please describe.
Pants uses patterns in the
.gitignore
to find additional files to ignore: https://www.pantsbuild.org/docs/reference-global#section-pants-ignore-use-gitignoreHowever, Git itself also looks at
$GIT_DIR/info/exclude
(usually.git/info/exclude
) and$XDG_CONFIG_DIR/git/ignore
(usually~/.config/git/ignore
, unlesscore.excludeFiles
in~/.gitconfig
is set differently) to get additional ignore patterns: https://git-scm.com/docs/gitignore.Describe the solution you'd like
It would be good if Pants supported these locations too.
This request is similar to #5682 but potentially simpler, as the interpretation of the patterns in these other ignore files is the same (they are relative to the repository root rather than some other location) and there is a fixed number of them.
Describe alternatives you've considered
You can replicate the additional ignore patterns in
.pants.rc
The text was updated successfully, but these errors were encountered: