Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pnpm for the javascript backend #18527

Closed
tobni opened this issue Mar 18, 2023 · 0 comments · Fixed by #18864
Closed

Add support for pnpm for the javascript backend #18527

tobni opened this issue Mar 18, 2023 · 0 comments · Fixed by #18864
Labels
backend: JavaScript JavaScript backend-related issues enhancement

Comments

@tobni
Copy link
Contributor

tobni commented Mar 18, 2023

Is your feature request related to a problem? Please describe.
Some users might prefer pnpm over npm, most likely because they're migrating a codebase.

Describe the solution you'd like
Users can pick a default package manager for the project in the nodejs subsystem. Users can also choose a particular package manager for different package_json targets (a nodejs resolve should require the same one for all, though).

Describe alternatives you've considered
Only support npm. Will make some adopters shy away

Additional context
Blocked on #18525
@tobni tobni changed the title Add support for pnpm Add support for pnpm for the javascript bakend Mar 18, 2023
@huonw huonw added the backend: JavaScript JavaScript backend-related issues label Mar 18, 2023
@tobni tobni changed the title Add support for pnpm for the javascript bakend Add support for pnpm for the javascript backend Mar 19, 2023
@tobni tobni mentioned this issue Apr 30, 2023
Merged
benjyw pushed a commit that referenced this issue May 2, 2023
@tobni
javascript: Add support for the pnpm package manager (#18864)
c3e20d7 
Enable to configure `pnpm` at the nodejs project or repository level,
via corepack.

Fixes #18527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: JavaScript JavaScript backend-related issues enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

javascript: Add support for the pnpm package manager tobni/pants
2 participants
@huonw @tobni