Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity files collide when generating node modules #19235

Open
Tracked by #19240
tobni opened this issue Jun 3, 2023 · 1 comment · May be fixed by #20826
Open
Tracked by #19240

Integrity files collide when generating node modules #19235

tobni opened this issue Jun 3, 2023 · 1 comment · May be fixed by #20826
Labels
backend: JavaScript JavaScript backend-related issues bug

Comments

@tobni
Copy link
Contributor

tobni commented Jun 3, 2023

Describe the bug
Newer versions of package managers generate integrity files (e.g .package-lock.json, notice the leading .).
The current strategy of merging node_modules installations across workspaces will collide in these integrity files,
because the digests were generated from subsets, and but the integrity file is in the same location on disk.

Pants version
Which version of Pants are you using?

OS
Are you encountering the bug on MacOS, Linux, or both?

Additional info

@riisi
Copy link
Contributor

riisi commented Apr 28, 2024

Note - these are called "hidden lockfiles" in npm - https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#hidden-lockfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JavaScript JavaScript backend-related issues bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants