Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install entire node project when creating node_modules digest, subset in sandboxes #19236

Open
Tracked by #19240
tobni opened this issue Jun 3, 2023 · 0 comments · May be fixed by #20826
Open
Tracked by #19240

Install entire node project when creating node_modules digest, subset in sandboxes #19236

tobni opened this issue Jun 3, 2023 · 0 comments · May be fixed by #20826
Labels
backend: JavaScript JavaScript backend-related issues enhancement

Comments

@tobni
Copy link
Contributor

tobni commented Jun 3, 2023

Is your feature request related to a problem? Please describe.
Currently, node_modules installations are crafted from installing the "owning" workspace, and all its deps seperately, followed by a digest merge.

This is problematic, especially considering #19235.
Even more so is the fact that the total runtime of pants not benefit from the "incremental" approach, as node_modules is resolved at the project level by the package manager, not per workspace.

Describe the solution you'd like
Install entire project once.

Describe alternatives you've considered

Additional context

@tobni tobni added enhancement backend: JavaScript JavaScript backend-related issues labels Jun 3, 2023
@tobni tobni changed the title Install entire workspace, subset in sandboxes Install entire node project when creating node_modules digest, subset in sandboxes Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JavaScript JavaScript backend-related issues enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant