Expose pex's --check validation
#19957
Labels
Comments
|
See pex-tool/pex#2253 (comment) for exploration of showing this via |
cburroughs
added a commit
to cburroughs/pants
that referenced
this issue
Feb 1, 2024
Pants has traditionally run Pex with --no-emit-warnings which as the name implies... doesn't emit warnings. This hides pertinent information like "the pex file you created won't actually work" from the user and sends them off on a debugging hunt. * Create an `emit_warnings` option, defaulting to True like the underlying tool.. * A little logic for pipeing Pex's stderr to Pants' logging. ref pantsbuild#19957
cburroughs
added a commit
to cburroughs/pants
that referenced
this issue
Feb 1, 2024
Pex exposes the `--check` flag to "check" if the resulting zipapp can be opened by CPython. Plumb that through so that Pants stops making PEXs that won't work at runtime. NOTE: The default of `error` differs from Pex. I'm struggling to think of a case where one would want a zipapp CPython can't open and Pants has a history of swalling warnings from Pex (`warn` is Pex's default). ref pantsbuild#19957
huonw
pushed a commit
that referenced
this issue
Feb 8, 2024
Pex exposes the `--check` flag to "check" if the resulting zipapp can be opened by CPython. Plumb that through so that Pants stops making PEXs that won't work at runtime. ref #19957
kaos
pushed a commit
that referenced
this issue
Feb 15, 2024
Pants has traditionally run Pex with --no-emit-warnings which as the name implies... doesn't emit warnings. This hides pertinent information like "the pex file you created won't actually work" from the user and sends them off on a debugging hunt. * Create an `emit_warnings` option, defaulting to True like the underlying tool.. * A little logic for pipeing Pex's stderr to Pants' logging. * Fix the logic for old per target `emit_warnings` that didn't quite work. ref #19957
|
This can be closed now, correct? |
|
Yeah! #20481 / #20480 seen to get this done. Thanks @cburroughs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In 2.1.148 (pex-tool/pex#2247 / pex-tool/pex#2253), PEX adds support for
--check=...to give build-time warnings/errors about--layout=zipappPEXes that are likely to not be able to be loaded by a Python interpreter, e.g. so many files or large enough to require "ZIP64" extensions, whichzipimportdoesn't handle (python/cpython#77140).This likely affects large PEXes including machine learning packages like PyTorch.
Describe the solution you'd like
For the
pex_binarytarget:checkoption somehowDescribe alternatives you've considered
A general mechanism for showing warnings
Additional context
N/A
The text was updated successfully, but these errors were encountered: