Building internal PEXes for built-in tools with [pex].emit_warnings shows warnings that seem useless
#20577
Comments
|
Heya @cburroughs, thanks for exposing the warnings. Do you have thoughts on this consequence of it? |
|
In general this is surfacing the type of issues like #19514 that users run into which would be good to have dogfooded answer for. In this case, I'm confused by how we got there though. Shouldn't Pants be using the bundled version of PBS from scie-pants? |
This is a short-term workaround for #20577 and #20586, where Pants' internal/default use of Pex triggers user-visible warnings, and those warnings are now visible due to #20480... so, instead of showing them by default, let's hide them for now. Users with desire for insight into the warnings can still enable this. Doing this means we're not having to rush in fixes for the root causes of these warnings for 2.20.0 stable release, and thus reduce feature-creep/risk. We can/should reenable warnings by default in a future release. Per @cburroughs's idea in #20586 (comment), this explicitly switches it on for the Pants repo itself, so we're eating our own dogfood and catching real and/or spurious errors earlier.
This is a short-term workaround for #20577 and #20586, where Pants' internal/default use of Pex triggers user-visible warnings, and those warnings are now visible due to #20480... so, instead of showing them by default, let's hide them for now. Users with desire for insight into the warnings can still enable this. Doing this means we're not having to rush in fixes for the root causes of these warnings for 2.20.0 stable release, and thus reduce feature-creep/risk. We can/should reenable warnings by default in a future release. Per @cburroughs's idea in #20586 (comment), this explicitly switches it on for the Pants repo itself, so we're eating our own dogfood and catching real and/or spurious errors earlier.
…#20593) This is a short-term workaround for #20577 and #20586, where Pants' internal/default use of Pex triggers user-visible warnings, and those warnings are now visible due to #20480... so, instead of showing them by default, let's hide them for now. Users with desire for insight into the warnings can still enable this. Doing this means we're not having to rush in fixes for the root causes of these warnings for 2.20.0 stable release, and thus reduce feature-creep/risk. We can/should reenable warnings by default in a future release. Per @cburroughs's idea in #20586 (comment), this explicitly switches it on for the Pants repo itself, so we're eating our own dogfood and catching real and/or spurious errors earlier. Co-authored-by: Huon Wilson <huon@exoflare.io>
|
Removing this from the 2.20.x milestone, since we landed #20593 as a stop-gap to reduce severity in 2.20.0 |
huonw
changed the title
|
Is there something actionable/blocking for 2.21 here? (I'd like to change the default, but I think that's a new feature at this point.) |
|
Ah, yes, thanks, I think this is now fully covered by #20586. The stopgap from #20590 is still around in 2.21 (and 2.22 etc.): https://github.com/pantsbuild/pants/blob/2.21.x/src/python/pants/backend/python/util_rules/pex_environment.py#L85 |
|
Oh, wait, hm, no, #20586 covers tests related to Pants' dependencies. The warnings are there for built-in tools. I'll reframe this one. |
huonw
changed the title
[pex].emit_warnings shows warnings that seem useless
huonw
changed the title
[pex].emit_warnings shows warnings that seem useless[pex].emit_warnings shows warnings that seem useless
|
And indeed, not blocking for 2.21 👍 |
Describe the bug
In 2.20.x, we're introduced the
[pex].emit_warningsoption (https://www.pantsbuild.org/2.20/reference/subsystems/pex#emit_warnings) to be able to surface more warnings from PEX, but building internal PEXes for builtin tools can show the warnings. Users can't do anything about them. This option is thus off by default.For instance:
Running that shows:
There's a big chunk of PEX warnings, that I don't think I as a normal user can do anything to silence as they seem to be about some PEXes that pants is building internally. (I could change the interpreters I have installed, but that doesn't seem appropriate.)
Pants version
2.20, 2.21, 2.22
This was previously shown by default, which was a regression between that and 2.20.0.dev7 likely related to #20480.
We turned down the default level in #20590.
OS
macOS
Additional info
N/A
The text was updated successfully, but these errors were encountered: