Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval error for option strings ending in certain types of quotes #3304

Closed
stuhood opened this issue Apr 29, 2016 · 0 comments
Closed

Eval error for option strings ending in certain types of quotes #3304

stuhood opened this issue Apr 29, 2016 · 0 comments
Assignees
@baroquebobcat
Labels
bug

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Apr 29, 2016

Passing an option like:

--jvm-run-jvm-program-args='-dtab.add="/s/blah=>/srv#/blah"'

fails with:

ParseError: The value cannot be evaluated as a literal expression: EOL while scanning string literal (<string>, line 1)
Given raw value:
1: [r"""-dtab.add="/s/blah=>/srv#/blah""""]
@stuhood stuhood added the bug label Apr 29, 2016
@baroquebobcat baroquebobcat assigned baroquebobcat and unassigned benjyw May 3, 2016
stuhood pushed a commit that referenced this issue May 15, 2016
@baroquebobcat @stuhood
Handle values for list options that end with quotes
283fca0 
The current implementation will raise an error if a list option provided using the extend syntax ends with a double quote. This adds code to handle that case.

Testing Done:
Wrote regression tests in the unit test suite. Saw them fail. Made them pass. CI away in the PR (3327).

Bugs closed: 3304, 3327

Reviewed at https://rbcommons.com/s/twitter/r/3813/

closes #3304, closes #3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baroquebobcat baroquebobcat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baroquebobcat @stuhood @benjyw