Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--test-junit-per-test-timer option no longer renders times #4159

Closed
stuhood opened this issue Jan 3, 2017 · 5 comments
Closed

--test-junit-per-test-timer option no longer renders times #4159

stuhood opened this issue Jan 3, 2017 · 5 comments

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Jan 3, 2017

It looks like this has been broken since 25896e7, but should be fairly easy to re-add.

@stuhood stuhood changed the title --per-test-timer option no longer renders times --test-junit-per-test-timer option no longer renders times Jan 3, 2017
@wslulciuc
Copy link
Contributor

@stuhood I can pick up this issue.

@stuhood
Copy link
Sponsor Member Author

stuhood commented Jan 4, 2017

@wslulciuc : Thanks! Please see http://www.pantsbuild.org/howto_contribute.html with more info (and note that we've switched to using github PRs for review recently!).

@wslulciuc
Copy link
Contributor

wslulciuc commented Jan 17, 2017

@stuhood : When adding my changes to patch the test render times, I'm able to compile using ./pants compile src/java::, but any debug statement I add or changes I make doesn't take affect when running: ./pants test --test-junit-per-test-timer ./examples/tests/java:: (or for tests/java::). I'm sure there is something obvious that I'm missing.

@stuhood
Copy link
Sponsor Member Author

stuhood commented Jan 17, 2017

@wslulciuc : There is a publishing step necessary to begin consuming your changes in the repo, so seeing the changes from the python side takes two PRs, unfortunately. Thanks again!

@wslulciuc
Copy link
Contributor

@stuhood : Been a while since I've looked at this issue (though minor). I'll work on it this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants