New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: dev_tasks.rst shows obsolete signatures #433
Comments
Since we are here, the old execute method is used as an example in at least one other place [0]. [0] http://pantsbuild.github.io/internals.html?highlight=products#basic-task |
this is in |
asherf
added a commit
to asherf/pants
that referenced
this issue
Feb 2, 2021
2.11.1 (2021-01-20) ------------------- * Fixed support for newer setuptools (v42+). Contributed by Michał Górny in `pantsbuild#451 <https://github.com/pytest-dev/pytest-cov/pull/451>`_. 2.11.0 (2021-01-18) ------------------- * Bumped minimum coverage requirement to 5.2.1. This prevents reporting issues. Contributed by Mateus Berardo de Souza Terra in `pantsbuild#433 <https://github.com/pytest-dev/pytest-cov/pull/433>`_. * Improved sample projects (from the `examples <https://github.com/pytest-dev/pytest-cov/tree/master/examples>`_ directory) to support running `tox -e pyXY`. Now the example configures a suffixed coverage data file, and that makes the cleanup environment unnecessary. Contributed by Ganden Schaffner in `pantsbuild#435 <https://github.com/pytest-dev/pytest-cov/pull/435>`_. * Removed the empty `console_scripts` entrypoint that confused some Gentoo build script. I didn't ask why it was so broken cause I didn't want to ruin my day. Contributed by Michał Górny in `pantsbuild#434 <https://github.com/pytest-dev/pytest-cov/pull/434>`_. * Fixed the missing `coverage context <https://coverage.readthedocs.io/en/stable/contexts.html>`_ when using subprocesses. Contributed by Bernát Gábor in `pantsbuild#443 <https://github.com/pytest-dev/pytest-cov/pull/443>`_. * Updated the config section in the docs. Contributed by Pamela McA'Nulty in `pantsbuild#429 <https://github.com/pytest-dev/pytest-cov/pull/429>`_. * Migrated CI to travis-ci.com (from .org). https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst
asherf
added a commit
to asherf/pants
that referenced
this issue
Feb 3, 2021
2.11.1 (2021-01-20) ------------------- * Fixed support for newer setuptools (v42+). Contributed by Michał Górny in `pantsbuild#451 <https://github.com/pytest-dev/pytest-cov/pull/451>`_. 2.11.0 (2021-01-18) ------------------- * Bumped minimum coverage requirement to 5.2.1. This prevents reporting issues. Contributed by Mateus Berardo de Souza Terra in `pantsbuild#433 <https://github.com/pytest-dev/pytest-cov/pull/433>`_. * Improved sample projects (from the `examples <https://github.com/pytest-dev/pytest-cov/tree/master/examples>`_ directory) to support running `tox -e pyXY`. Now the example configures a suffixed coverage data file, and that makes the cleanup environment unnecessary. Contributed by Ganden Schaffner in `pantsbuild#435 <https://github.com/pytest-dev/pytest-cov/pull/435>`_. * Removed the empty `console_scripts` entrypoint that confused some Gentoo build script. I didn't ask why it was so broken cause I didn't want to ruin my day. Contributed by Michał Górny in `pantsbuild#434 <https://github.com/pytest-dev/pytest-cov/pull/434>`_. * Fixed the missing `coverage context <https://coverage.readthedocs.io/en/stable/contexts.html>`_ when using subprocesses. Contributed by Bernát Gábor in `pantsbuild#443 <https://github.com/pytest-dev/pytest-cov/pull/443>`_. * Updated the config section in the docs. Contributed by Pamela McA'Nulty in `pantsbuild#429 <https://github.com/pytest-dev/pytest-cov/pull/429>`_. * Migrated CI to travis-ci.com (from .org). https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst
asherf
added a commit
to asherf/pants
that referenced
this issue
Feb 3, 2021
2.11.1 (2021-01-20) ------------------- * Fixed support for newer setuptools (v42+). Contributed by Michał Górny in `pantsbuild#451 <https://github.com/pytest-dev/pytest-cov/pull/451>`_. 2.11.0 (2021-01-18) ------------------- * Bumped minimum coverage requirement to 5.2.1. This prevents reporting issues. Contributed by Mateus Berardo de Souza Terra in `pantsbuild#433 <https://github.com/pytest-dev/pytest-cov/pull/433>`_. * Improved sample projects (from the `examples <https://github.com/pytest-dev/pytest-cov/tree/master/examples>`_ directory) to support running `tox -e pyXY`. Now the example configures a suffixed coverage data file, and that makes the cleanup environment unnecessary. Contributed by Ganden Schaffner in `pantsbuild#435 <https://github.com/pytest-dev/pytest-cov/pull/435>`_. * Removed the empty `console_scripts` entrypoint that confused some Gentoo build script. I didn't ask why it was so broken cause I didn't want to ruin my day. Contributed by Michał Górny in `pantsbuild#434 <https://github.com/pytest-dev/pytest-cov/pull/434>`_. * Fixed the missing `coverage context <https://coverage.readthedocs.io/en/stable/contexts.html>`_ when using subprocesses. Contributed by Bernát Gábor in `pantsbuild#443 <https://github.com/pytest-dev/pytest-cov/pull/443>`_. * Updated the config section in the docs. Contributed by Pamela McA'Nulty in `pantsbuild#429 <https://github.com/pytest-dev/pytest-cov/pull/429>`_. * Migrated CI to travis-ci.com (from .org). https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Eagle-eyed @mateor , while fixing a typo in https://rbcommons.com/s/twitter/r/809/diff noted that the page he was editing had deeper issues than a typo: "But it doesn't look like this is how execute methods are done anymore. I see execute(self) only..."
We should update the doc.
As a rule of thumb, a good way to keep the doc updated is...
...but if that's hard, maybe just update the page to reflect the new Task reality
The text was updated successfully, but these errors were encountered: