Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace `select()` syscall with `Selectors` module to fix `filedescriptors out of range` issue #7880
Twitter has 85 targets that fail to compile due to the message:
We don't encounter this in Pants CI, because we don't try to compile as many targets as Twitter does (1500+ for these tests).
In the process of researching this, I found that many view the
Beyond generally being less desirable to use
Proposed solution: Selectors library
Beyond nice abstractions, the main benefit we get is the class
Handling Python 2 compatibility
This module was only introduced in Python 3.4, and was not backported. There does exist a 3rdparty backport
However, because we plan to drop Python 2 any day now—and the Twitter tests were passing when using Python 2 to run Pants—I propose that we keep the Python 2 code exactly how it is using
This is outstanding research, thanks!
I couldn't find the specific place where we set a high
I'm definitely on board with using the