Remove BuildFile
#10102
Remove BuildFile
#10102
Conversation
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
| def __init__( | ||
| self, | ||
| build_file: Optional[BuildFile] = None, | ||
| target_name: Optional[str] = None, | ||
| rel_path: Optional[str] = None, | ||
| ) -> None: | ||
| def __init__(self, *, rel_path: str, target_name: Optional[str] = None) -> None: |
There was a problem hiding this comment.
This is a little not-Kosher to make it kwargs-only. But I think it's safe enough to do.
Because rel_path can no longer be optional, it no longer has a default arg. So, it must come before target_name in the params list. This would be dangerous to reorder if people were using positional args, because they're both str. Instead, kwargs-only will make the error more explicit.
I also don't think this will hit many people because build_file was the first positional arg, and you can't give both build_file and rel_path, so I suspect that most people were already using kwargs. Otherwise they would have used BuildFileAddress(None, "target", "src/python/pants").
There was a problem hiding this comment.
I think this is OK, but let's hear from @stuhood ?
| def __init__( | ||
| self, | ||
| build_file: Optional[BuildFile] = None, | ||
| target_name: Optional[str] = None, | ||
| rel_path: Optional[str] = None, | ||
| ) -> None: | ||
| def __init__(self, *, rel_path: str, target_name: Optional[str] = None) -> None: |
There was a problem hiding this comment.
I think this is OK, but let's hear from @stuhood ?
We are now able to remove our last use of
BuildFile: the constructor forBuildFileAddress.[ci skip-rust-tests]
[ci skip-jvm-tests]