Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --v2-ui in favor of --dynamic-ui #10105

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Remove deprecated --v2-ui in favor of --dynamic-ui #10105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013c59b
Remove deprecated `--v2-ui` in favor of `--dynamic-ui`
Eric-Arellano Jun 20, 2020
ccecb4b
Fix lint
Eric-Arellano Jun 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/python/pants/bin/local_pants_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from pants.base.build_environment import get_buildroot
from pants.base.cmd_line_spec_parser import CmdLineSpecParser
from pants.base.deprecated import resolve_conflicting_options
from pants.base.exception_sink import ExceptionSink
from pants.base.exiter import PANTS_FAILED_EXIT_CODE, PANTS_SUCCEEDED_EXIT_CODE, ExitCode
from pants.base.specs import Specs
Expand All @@ -31,7 +30,6 @@
from pants.option.arg_splitter import UnknownGoalHelp
from pants.option.options import Options
from pants.option.options_bootstrapper import OptionsBootstrapper
from pants.option.scope import GLOBAL_SCOPE
from pants.reporting.reporting import Reporting
from pants.reporting.streaming_workunit_handler import StreamingWorkunitHandler
from pants.subsystem.subsystem import Subsystem
Expand Down Expand Up @@ -87,18 +85,7 @@ def _init_graph_session(
)

global_scope = options.for_global_scope()

if global_scope.v2:
dynamic_ui = resolve_conflicting_options(
old_option="v2_ui",
new_option="dynamic_ui",
old_scope=GLOBAL_SCOPE,
new_scope=GLOBAL_SCOPE,
old_container=global_scope,
new_container=global_scope,
)
else:
dynamic_ui = False
dynamic_ui = global_scope.dynamic_ui if global_scope.v2 else False
use_colors = global_scope.get("colors", True)

zipkin_trace_v2 = options.for_scope("reporting").zipkin_trace_v2
Expand Down
9 changes: 0 additions & 9 deletions src/python/pants/option/global_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,15 +974,6 @@ def register_options(cls, register):
help="Display a dynamically-updating console UI as pants runs.",
)

register(
"--v2-ui",
default=False,
type=bool,
removal_version="1.31.0.dev0",
removal_hint="Use --dynamic-ui instead.",
help="Whether to show v2 engine execution progress.",
)

register(
"--dependency-inference",
default=False,
Expand Down