Remove watchman. #10114
Merged
Remove watchman. #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-jvm-tests]
stuhood
force-pushed
the
stuhood/remove-watchman
branch
from
9f7b511
to
4b44172
Compare
Eric-Arellano
approved these changes
Jun 21, 2020
| @@ -38,7 +38,7 @@ Services | |||
|
|
|||
| A Pants Daemon process has several services that it polls in order. Every service runs in a separate thread, and can be paused, resumed or terminated. Services can communicate with each other. | |||
|
|
|||
| Examples of services are [`FSEventService`](https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/service/fs_event_service.py#14), which takes care of listening for watchman events, [`SchedulerService`](https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/service/scheduler_service.py#21), which takes care of listening responding to those events to keep a warm `Graph`, and [`PailgunService`](https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/service/pailgun_service.py#15), which listens to `SchedulerService` and manages the lifetime of a `PailgunServer` responsible for spawning pants runs when requested by clients, it takes a `DaemonPantsRunner` as one of its arguments, to use as a template to spawn pants runs when requested by the clients. | |||
| Examples of services are [`SchedulerService`](https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/service/scheduler_service.py#21), which takes care of listening responding to those events to keep a warm `Graph`, and [`PailgunService`](https://github.com/pantsbuild/pants/blob/master/src/python/pants/pantsd/service/pailgun_service.py#15), which listens to `SchedulerService` and manages the lifetime of a `PailgunServer` responsible for spawning pants runs when requested by clients, it takes a `DaemonPantsRunner` as one of its arguments, to use as a template to spawn pants runs when requested by the clients. | |||
There was a problem hiding this comment.
FYI the plan is to get rid of the old docsite on the main branch. We will still have the docsite with the 1.30 branch and will publish all updates from that branch.
Why remove on main? We wouldn't be able to keep the original docsite with all of these deletions. For example, I recently deleted the Go README, which was used for the docsite.
--
So, you'll either want to port to the new site, or cherry-pick this change into 1.30.
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Mar 31, 2021
[ci skip-jvm-tests]
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Mar 31, 2021
[ci skip-jvm-tests]
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
Apr 5, 2021
[ci skip-jvm-tests]
benjyw
added a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.