Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using unstripped python sources #10138

Merged
merged 11 commits into from Jun 24, 2020

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Jun 23, 2020

The old ImportablePythonSources concept is now named StrippedPythonSources,
and introduces a new UnstrippedPythonSources concept, which is similar, except
without stripping source roots.

[ci skip-rust-tests]
[ci skip-jvm-tests]

@benjyw benjyw marked this pull request as draft June 23, 2020 19:33
@benjyw benjyw changed the title WIP Don't strip source roots when running pytest. Jun 23, 2020
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would be surprised if coverage still works with this change - the IT will likely fail.

If this happens, I recommend reverting the pytest_runner.py change and landing the rest, so that we can handle the merge conflict with my pending change.

@benjyw benjyw marked this pull request as ready for review June 23, 2020 22:57
[ci skip-rust-tests]
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
[ci skip-jvm-tests]
[ci skip-rust-tests]
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
@benjyw benjyw changed the title Don't strip source roots when running pytest. Support for using unstripped python sources Jun 24, 2020
…oot_stripping

[ci skip-rust-tests]
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests.
[ci skip-rust-tests]
# Delete this line to force CI to run the JVM tests.
[ci skip-jvm-tests]
…oot_stripping

[ci skip-rust-tests]
[ci skip-jvm-tests]
@Eric-Arellano Eric-Arellano merged commit e4db7d4 into pantsbuild:master Jun 24, 2020
@benjyw benjyw deleted the no_source_root_stripping branch July 15, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants