New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for using unstripped python sources #10138
Merged
Eric-Arellano
merged 11 commits into
pantsbuild:master
from
benjyw:no_source_root_stripping
Jun 24, 2020
Merged
Support for using unstripped python sources #10138
Eric-Arellano
merged 11 commits into
pantsbuild:master
from
benjyw:no_source_root_stripping
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
force-pushed
the
no_source_root_stripping
branch
from
June 23, 2020 21:09
2714daf
to
2e7c6e0
Compare
Eric-Arellano
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would be surprised if coverage still works with this change - the IT will likely fail.
If this happens, I recommend reverting the pytest_runner.py
change and landing the rest, so that we can handle the merge conflict with my pending change.
src/python/pants/backend/python/rules/importable_python_sources.py
Outdated
Show resolved
Hide resolved
[ci skip-rust-tests] [ci skip-jvm-tests]
[ci skip-jvm-tests]
benjyw
force-pushed
the
no_source_root_stripping
branch
from
June 24, 2020 00:59
2e7c6e0
to
56f7b00
Compare
[ci skip-rust-tests] [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
benjyw
changed the title
Don't strip source roots when running pytest.
Support for using unstripped python sources
Jun 24, 2020
…oot_stripping [ci skip-rust-tests] [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
…oot_stripping [ci skip-rust-tests] [ci skip-jvm-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
ImportablePythonSources
concept is now namedStrippedPythonSources
,and introduces a new
UnstrippedPythonSources
concept, which is similar, exceptwithout stripping source roots.
[ci skip-rust-tests]
[ci skip-jvm-tests]