Revert "Make SnapshotSubset() faster (#9779)" #10143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 54ff280. [ci skip-jvm-tests]
cosmicexplorer
added a commit
to cosmicexplorer/pants
that referenced
this pull request
Jun 24, 2020
…sbuild#10143)" This reverts commit fa093eb. [ci skip-jvm-tests]
cosmicexplorer
added a commit
that referenced
this pull request
Jun 24, 2020
[ci skip-jvm-tests] ### Problem This fixes the tests that were broken by #9779! This looked like a timeout, but was actually an assertion failure (an assertion that shouldn't have been asserted). Reverts #10143. ### Solution - Correctly process trailing `/**` globs. - Fix up the snapshot subset python tests, which have different, more correct answers now. - **Note: reviewers, please make sure the changes to these test results make sense!** ### Result master is unbroken, and a bug in #9779 is fixed! #9967 remains as follow up tech debt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 54ff280.
[ci skip-jvm-tests]
Problem
This breaks master!
src/python/pants/engine:teststimes out running thetest_snapshot_subset_globs()method!Solution
Result
Master is fixed!