Remove v1 login, server, and killserver goals
#10144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
stuhood
approved these changes
Jun 23, 2020
| import logging | ||
|
|
||
| from pants.base.exceptions import TaskError | ||
| from pants.reporting.reporting_server import ReportingServerManager |
There was a problem hiding this comment.
ReportingServerManager is only accessible via these tasks I think. cc @benjyw
There was a problem hiding this comment.
Agreed. I started to remove the whole file but stopped because some of it was used in reporting.py and it looked too intricate to remove in this PR.
[ci skip-jvm-tests] [ci skip-rust-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.30.x is expected to be the last release in the Pants 1.x series. Pants 2.x will no longer support the v1 engine, meaning these tasks will no longer work.
For anyone who still needs this functionality, we will give instructions and a script for users to be able to keep using Pants 1.x and Pants 2.x side-by-side. Given enough user interest, we can also port this functionality to the v2 engine or help users to write a plugin.
[ci skip-jvm-tests]
[ci skip-rust-tests]