Preserve source roots in MyPy and Pylint output #10159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
7 tasks
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
Eric-Arellano
commented
Jun 24, 2020
Comment on lines
-88
to
+93
| # TODO(#10131): figure out how to robustly handle interpreter constraints. Unlike other | ||
| # linters, the version of Python used to run MyPy can be different than the version of | ||
| # the code. | ||
| # NB: This only determines what MyPy is run with. The user can specify what version | ||
| # their code is with `--python-version`. See | ||
| # https://mypy.readthedocs.io/en/stable/config_file.html#platform-configuration. We do | ||
| # not auto-configure this for simplicity and to avoid Pants magically setting values for | ||
| # users. |
There was a problem hiding this comment.
This is after discussion with Benjy yesterday.
There would be some complexities if Pants were to try to auto-configure --python-version:
- Difficult to actually do. MyPy expects a 2-digit number like
3.6, but our interpreter constraints express ranges like>3.6. It's not clear how to translate a more general constraint into something more specific. - We would need to then validate that the user did not try setting this and is now conflicting with us. Sounds leaky.
benjyw
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (Pylint):
After (Pylint):