Preserve source roots with Pytest output #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] [ci skip-rust-tests]
benjyw
approved these changes
Jun 25, 2020
| @@ -251,9 +245,10 @@ async def run_python_test( | |||
| if use_coverage: | |||
| output_files.append(".coverage") | |||
|
|
|||
| # We explicitly add the CWD to the PEX runtime sys.path. Some pytest plugins | |||
There was a problem hiding this comment.
I'm not sure the django example will still work, but if not I'll fix it, so this is fine for now.
There was a problem hiding this comment.
Okay, thank you! If it turns out this breaks, it would be good to add a unit test.
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
…-strip [ci skip-rust-tests] [ci skip-jvm-tests]
…-strip [ci skip-rust-tests]
…how up in the result We must use `python_sources.py` to properly inject any missing `__init__.py` files at the report time. This allows us to remove `--ignore-errors`, which is good to make it more likely for us to discover issues with the project. [ci skip-rust-tests] # Conflicts: # src/python/pants/backend/python/rules/coverage.py # src/python/pants/backend/python/rules/coverage_integration_test.py
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
…-strip [ci skip-rust-tests] # Conflicts: # src/python/pants/backend/python/rules/coverage.py # src/python/pants/backend/python/rules/coverage_plugin/BUILD # src/python/pants/backend/python/rules/pytest_runner_integration_test.py
… the instance of pants that we are testing. # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
asherf
approved these changes
Jul 7, 2020
The issue was never fixed with #10064 (IOW the random.py file is still not expected in the |
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jul 31, 2021
Previously, the combination of collecting relative_paths and passing `--cov=.` to pytest-cov could lead to coverage collection of invalid paths (namely: "(builtin)") which would cause coverage report generation to fail. Fix this by restricting coverage to the source roots of the code under test. This also solves a regression introduced by pantsbuild#10165. Fixes pantsbuild#12390 [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Jul 31, 2021
Previously, the combination of collecting relative_paths and passing `--cov=.` to pytest-cov could lead to coverage collection of invalid paths (namely: "(builtin)") which would cause coverage report generation to fail. Fix this by restricting coverage to the source roots of the code under test. This also solves a regression introduced by #10165. Fixes #12390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After
This also allows us to remove the custom Pants Coverage plugin, which greatly simplifies the code path and improves performance (8s to run coverage on
pants_test/util:objectsbefore, and only 4 seconds after). This does introduce a regression that we no longer report on files never touched by the test, but this was a similar issue before that we already had to solve. We will fix this problem as part of #10064.[ci skip-jvm-tests]
[ci skip-rust-tests]