Simplify Get implementation post deprecations. #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-jvm-tests]
stuhood
force-pushed
the
stuhood/simplify-get-impl
branch
from
f5c40aa
to
c698f9c
Compare
Eric-Arellano
approved these changes
Jun 26, 2020
| """Allow a Get to be `await`ed within an `async` method, returning a strongly-typed result. | ||
| + Short form | ||
| a. Get(<ProductType>, <SubjectType>(<constructor args for subject>)) | ||
| b. Get[<ProductType>](<SubjectType>(<constructor args for subject>)) |
| subject: _SubjectType | ||
| + Long form: | ||
| a. Get(<ProductType>, <SubjectType>, subject) | ||
| b. Get[<ProductType>](<SubjectType>, subject) |
There was a problem hiding this comment.
Mm: will fix in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the removal of deprecated
Getsyntax there were some other simplifications available for the implementation.Solution
Remove a few levels of indirection in
Getconstruction. In particular: theSubjectDeclaredTypeis always equal toType[SubjectType], and so doesn't need a separate type variable. Additionally, theGetMakerandGetFactoryclasses could be inlined intoGet's constructor.Result
Simpler implementation, equivalent API and typecheckability.
[ci skip-jvm-tests]