Properly handle PEP 420 namespace packages #10183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
benjyw
approved these changes
Jun 27, 2020
I can't figure out how to get PEP 420 working with MyPy # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
Why is MyPy so much harder to get working?! # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
…it__.py # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
…ting-inits [ci skip-rust-tests]
…ting-inits [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
|
MyPy is still not working like I'd expect, but going to merge this because it makes substantial progress for multiple different Python tasks. Will fix MyPy in a dedicated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using PEP 420 namespace packages, you must leave off the
__init__.pyfile. However, Pants was automatically injecting__init__.pyfiles when missing, which would break PEP 420.For example, Toolchain does not use
__init__.pyand has bothsrc/python/toolchain/andtest/python/toolchain/, which both map to the moduletoolchain. So, v2 MyPy was failing because it detected an empty__init__.pyfile in both packages.Solution
Stop ever generating
__init__.pyfiles, now that we automatically read them from the filesystem via #10166.This means that Pants will much closer emulate real Python semantics. If a user is using PEP 420, we'll respect that. If they are missing
__init__.pyand it would cause normal Python to fail, we will also fail, rather than trying to magically fix the issue.This PR also fixes our auto-discovery of
PathGlobswhen the input snapshot was stripped. The logic failed to account for how the input is stripped, yetPathGlobsis never stripped.[ci skip-rust-tests]