Remove --zipkin-trace-v2 option #10184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jun 27, 2020
| @@ -51,68 +50,6 @@ def test_zipkin_reporter_with_zero_sample_rate(self): | |||
| num_of_traces = len(ZipkinHandler.traces) | |||
| self.assertEqual(num_of_traces, 0) | |||
|
|
|||
There was a problem hiding this comment.
The test above this looks dead as well?
| @@ -94,13 +94,6 @@ def register_options(cls, register): | |||
| default=100.0, | |||
| help="Rate at which to sample Zipkin traces. Value 0.0 - 100.0.", | |||
| ) | |||
There was a problem hiding this comment.
I expect that there is a lot more code in here related to zipkin that can be removed.
gshuflin
force-pushed
the
remove_zipkin_trace
branch
from
8261b8c
to
946d87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the --zipkin-trace-v2 option and tests using it. In the v2 world, we will implement zipkin tracing (if necessary) with a plugin that consumes streaming workunits. This also allows us to remove the
get_workunitsrust FFI function, which was only used to implement this functionality, and no longer have to pass around the zipkin tracing boolean in rust code.