Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 portions of backend/native and ipex #10187

Merged
merged 5 commits into from Jun 29, 2020

Conversation

Eric-Arellano
Copy link
Contributor

In Pants 2.0, we are deleting all v1 abstractions like Task and build_graph.Target. Unfortunately, this means that we cannot preserve all of backend/native. We keep the rules-based code, though.

[ci skip-rust-tests]

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
Copy link
Contributor Author

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Danny, let me know if there are things that we can still keep that I left out. The main intent of this PR is to allow us to remove things like Task and build_graph.Target; the intent is not to remove this backend outright.

# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended.
[ci skip-rust-tests]
@Eric-Arellano Eric-Arellano changed the title Remove v1 portions of backend/native Remove v1 portions of backend/native and ipex Jun 29, 2020
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eric-Arellano Eric-Arellano merged commit b2428e7 into pantsbuild:master Jun 29, 2020
@Eric-Arellano Eric-Arellano deleted the remove-native branch June 29, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants