Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated assertEquals #10197

Merged
merged 1 commit into from Jun 30, 2020
Merged

Stop using deprecated assertEquals #10197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/python/pants_test/integration/goal_rule_integration_test.py
View file
Open in desktop
Expand Up @@ -78,10 +78,9 @@ def dump(content):
# Verify that the three different target states were listed, and that the process exited.
pants_result = handle.join()
self.assert_success(pants_result)
self.assertEquals(
[f"{rel_tmpdir}:{name}" for name in ("one", "two", "three")],
list(pants_result.stdout_data.splitlines()),
)
assert [
f"{rel_tmpdir}:{name}" for name in ("one", "two", "three")
] == pants_result.stdout_data.splitlines()

def test_unimplemented_goals_noop(self) -> None:
# If the goal is actually run, it should fail because V2 `run` expects a single target and will
Expand Down