Refactor coverage tests #10209
Merged
Refactor coverage tests #10209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to add more coverage tests
Eric-Arellano
approved these changes
Jun 30, 2020
src/python/pants/backend/python/rules/coverage_integration_test.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/rules/coverage_integration_test.py
Outdated
Show resolved
Hide resolved
…t.py Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
…t.py Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add more coverage tests
Problem
A single test method runs two different test scenarios.
this makes it harder to understand failures and add more tests..
https://github.com/pantsbuild/pants/pull/10209/files?w=1
Solution
Refactor logic and put it in reusable methods.
Result
Adding tests for more scenarios is now easier, see #9997 (review)
Will follow up on this PR with tests for running coverage with HTML and XML report types.