Remove the concept of a scope category. #10224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v2 all optionables are subsystems, even global options. There is no meaning to categories any more. [ci skip-rust-tests]
Eric-Arellano
approved these changes
Jul 1, 2020
| @@ -54,22 +50,9 @@ def deprecated_cache_setup_removal_version(cls): | |||
| """ | |||
| return None | |||
|
|
|||
| @classmethod | |||
| def conflict_free_name(cls): | |||
There was a problem hiding this comment.
By the way, v2 setup-py is still setup-py2:
pants/src/python/pants/backend/python/rules/run_setup_py.py
Lines 225 to 238 in 239f887
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
Eric-Arellano
approved these changes
Jul 1, 2020
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
Instead use --plugins/--backend-packages, as there is now no v1 to get in the way. [ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
[ci skip-rust-tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2 all optionables are subsystems, even global options.
There is no meaning to categories any more.
[ci skip-rust-tests]