Get rid of --plugins2/--backend-packages2. #10231
Conversation
Instead use --plugins/--backend-packages, as there is now no v1 to get in the way. [ci skip-rust-tests]
There was a problem hiding this comment.
Yay! My only concern is @cosmicexplorer 's concerns about still needing global_subsystem for CAFOs to work properly. See https://pantsbuild.slack.com/archives/C0D7TNJHL/p1593640144415700
If we can get it working via SubsystemRule, great. Otherwise, we might need to keep around global_subsystem and don't document it.
|
Note that I'm pretty sure the only blocker for removing twitter's dependency on CAOF is that v2 macros can't access option values. When that is possible we could also deprecate CAOF at some point, depending upon the needs of the community. |
|
PS I might add back the "2" versions of the options, with a deprecation notice, to ease the transition. But I first want to see that CI passes this way. |
|
OK, in that case we would still add that global_subystems support to v2 plugins, right? |
|
Yes, for now, since v2 plugins may contain context-aware object factories. |
Agreed. Like how we still will have |
[ci skip-rust-tests]
[ci skip-rust-tests]
# Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
[ci skip-rust-tests]
Instead reuse --plugins/--backend-packages, as there is
now no v1 to get in the way.
[ci skip-rust-tests]