Refactor WorkunitStore struct #10242

gshuflin · 2020-07-02T21:24:16Z

This commit introduces a number of refactoring changes on the WorkunitStore struct:

rename WorkUnitInnerStore to HeavyHittersInnerStore
reduce the scope of a number of locks
eliminate the separate started/completed workunit mpsc sender/receiver pairs by wrapping the data in an enum
move some methods to structs with reduced scope

stuhood

Thanks!

stuhood · 2020-07-06T19:35:23Z

src/rust/engine/workunit_store/src/lib.rs

+      let mut started_messages = vec![];
+      let mut completed_messages = vec![];
+
+      {


It doesn't look like the lock on self.workunit_records needs to be acquired while self.msg_rx is acquired here.

- Rename WorkUnitInnerStore - Reduce scope of locks - Reduce number of separate channels by using an enum

gshuflin requested a review from stuhood July 2, 2020 21:24

gshuflin force-pushed the refactor_workunits branch from 92d8e25 to c1107dc Compare July 6, 2020 18:24

stuhood approved these changes Jul 6, 2020

View reviewed changes

gshuflin force-pushed the refactor_workunits branch from 40db2bb to 9f91c3e Compare July 7, 2020 00:40

gshuflin added 3 commits July 7, 2020 10:55

Refactoring in WorkunitStore

8f56d19

- Rename WorkUnitInnerStore - Reduce scope of locks - Reduce number of separate channels by using an enum

Move around what structs methods are defined on

2deb852

Restrict lock more

20950cc

gshuflin force-pushed the refactor_workunits branch from 9f91c3e to 20950cc Compare July 7, 2020 17:55

gshuflin merged commit fbb8712 into pantsbuild:master Jul 7, 2020

gshuflin deleted the refactor_workunits branch July 7, 2020 20:07

Provide feedback