Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HydratedTarget, AddressMapper, and BuildGraph #10250

Merged
merged 2 commits into from Jul 3, 2020
Merged

Remove HydratedTarget, AddressMapper, and BuildGraph #10250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3956bc
Remove `HydratedField` and `SourcesField`
Eric-Arellano Jul 3, 2020
f41ac93
Remove `AddressMapper` and `BuildGraph`
Eric-Arellano Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/python/pants/backend/python/dependency_inference/BUILD
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@ python_library(
"src/python/pants/engine:selectors",
"src/python/pants/engine:unions",
"src/python/pants/engine/internals:native",
"src/python/pants/engine/legacy:structs",
"src/python/pants/util:memo",
"src/python/pants/util:ordered_set",
"src/python/pants/util:strutil",
Expand Down
2 changes: 0 additions & 2 deletions src/python/pants/backend/python/lint/BUILD
View file
Open in desktop
Expand Up @@ -6,7 +6,6 @@ python_library(
'3rdparty/python:dataclasses',
'src/python/pants/core/goals',
'src/python/pants/core/util_rules',
'src/python/pants/engine/legacy:structs',
'src/python/pants/engine:rules',
'src/python/pants/engine:unions',
],
Expand All @@ -26,7 +25,6 @@ python_tests(
'src/python/pants/engine:fs',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/subsystem',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/bandit/BUILD
View file
Open in desktop
Expand Up @@ -33,7 +33,6 @@ python_tests(
'src/python/pants/engine:fs',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:interpreter_selection_utils',
'src/python/pants/testutil:external_tool_test_base',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/black/BUILD
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ python_tests(
'src/python/pants/engine:fs',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/docformatter/BUILD
View file
Open in desktop
Expand Up @@ -33,7 +33,6 @@ python_tests(
'src/python/pants/engine:fs',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/flake8/BUILD
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ python_tests(
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine:unions',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:interpreter_selection_utils',
'src/python/pants/testutil:external_tool_test_base',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/isort/BUILD
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ python_tests(
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine:unions',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:external_tool_test_base',
'src/python/pants/testutil/option',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/lint/pylint/BUILD
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ python_tests(
'src/python/pants/engine:fs',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:interpreter_selection_utils',
'src/python/pants/testutil:external_tool_test_base',
Expand Down
8 changes: 1 addition & 7 deletions src/python/pants/backend/python/lint/pylint/rules_integration_test.py
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@
from pants.core.goals.lint import LintResults
from pants.engine.addresses import Address
from pants.engine.fs import FileContent
from pants.engine.legacy.graph import HydratedTargets
from pants.engine.rules import RootRule
from pants.engine.selectors import Params
from pants.engine.target import TargetWithOrigin, WrappedTarget
Expand Down Expand Up @@ -43,12 +42,7 @@ def target_types(cls):

@classmethod
def rules(cls):
return (
*super().rules(),
*pylint_rules(),
RootRule(PylintRequest),
RootRule(HydratedTargets),
)
return (*super().rules(), *pylint_rules(), RootRule(PylintRequest))

def make_target_with_origin(
self,
Expand Down
3 changes: 0 additions & 3 deletions src/python/pants/backend/python/rules/BUILD
View file
Open in desktop
Expand Up @@ -12,7 +12,6 @@ python_library(
'src/python/pants/core',
'src/python/pants/core/goals',
'src/python/pants/core/util_rules',
'src/python/pants/engine/legacy:graph',
'src/python/pants/engine:addresses',
'src/python/pants/engine:collection',
'src/python/pants/engine:fs',
Expand Down Expand Up @@ -48,8 +47,6 @@ python_tests(
'src/python/pants/engine:process',
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine/legacy:graph',
'src/python/pants/engine/legacy:structs',
'src/python/pants/python',
'src/python/pants/source',
'src/python/pants/testutil:interpreter_selection_utils',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/backend/python/typecheck/mypy/BUILD
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ python_tests(
'src/python/pants/engine:rules',
'src/python/pants/engine:selectors',
'src/python/pants/engine:unions',
'src/python/pants/engine/legacy:structs',
'src/python/pants/source',
'src/python/pants/testutil:interpreter_selection_utils',
'src/python/pants/testutil:external_tool_test_base',
Expand Down
3 changes: 0 additions & 3 deletions src/python/pants/bin/BUILD
View file
Open in desktop
Expand Up @@ -18,10 +18,7 @@ python_library(
'src/python/pants/engine/internals:core_abstractions',
'src/python/pants/engine/internals:native',
'src/python/pants/engine/internals:scheduler',
'src/python/pants/engine/legacy:address_mapper',
'src/python/pants/engine/legacy:graph',
'src/python/pants/engine/legacy:parser',
'src/python/pants/engine/legacy:round_engine',
'src/python/pants/engine:fs',
'src/python/pants/engine:unions',
'src/python/pants/goal',
Expand Down
1 change: 0 additions & 1 deletion src/python/pants/bin/local_pants_runner.py
View file
Open in desktop
Expand Up @@ -200,7 +200,6 @@ def _maybe_run_v2_body(self, goals, poll: bool) -> ExitCode:
return self.graph_session.run_goal_rules(
options_bootstrapper=self.options_bootstrapper,
union_membership=self.union_membership,
options=self.options,
goals=goals,
specs=self.specs,
poll=poll,
Expand Down
92 changes: 0 additions & 92 deletions src/python/pants/build_graph/address_mapper.py
View file
Open in desktop

This file was deleted.