Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remoting: make streaming client the default #10260

Merged
merged 1 commit into from Jul 8, 2020
Merged

remoting: make streaming client the default #10260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions pants.remote.toml
View file
Open in desktop
Expand Up @@ -23,9 +23,6 @@ remote_execution_extra_platform_properties = [
"container-image=docker://gcr.io/pants-remoting-beta/rbe-remote-execution@sha256:ec94526d1aa0604b7f693a0b1fb224ca7822a0d821ce20dff50ec808cad597b6",
]

# Enable the REv2 streaming client.
remote_execution_enable_streaming = true

# This should correspond to the number of workers running in Google RBE. See
# https://console.cloud.google.com/apis/api/remotebuildexecution.googleapis.com/quotas?project=pants-remoting-beta&folder&organizationId&duration=PT6H.
process_execution_remote_parallelism = 32
Expand Down
6 changes: 3 additions & 3 deletions src/python/pants/option/global_options.py
View file
Open in desktop
Expand Up @@ -138,7 +138,7 @@ def from_bootstrap_options(cls, bootstrap_options):
remote_oauth_bearer_token_path=None,
remote_execution_extra_platform_properties=[],
remote_execution_headers={},
remote_execution_enable_streaming=False,
remote_execution_enable_streaming=True,
remote_execution_overall_deadline_secs=60 * 60, # one hour
process_execution_local_enable_nailgun=False,
)
Expand Down Expand Up @@ -781,9 +781,9 @@ def register_bootstrap_options(cls, register):
register(
"--remote-execution-enable-streaming",
type=bool,
default=False,
default=DEFAULT_EXECUTION_OPTIONS.remote_execution_enable_streaming,
advanced=True,
help="Enable the streaming remote execution client (experimental).",
help="Enable the streaming remote execution client.",
)
register(
"--remote-execution-overall-deadline-secs",
Expand Down